Win installer upgrade #875
Conversation
…licates existing install behavior.
Added post-install git lfs initialization.
| #define MyAppVersion "1.1.0.0" | ||
| #define MyAppPublisher "GitHub, Inc" | ||
| #define MyAppURL "https://git-lfs.github.com/" | ||
| #define MyAppExeName "Git-LFS-Installer.exe" |
There was a problem hiding this comment.
Instead of defining this here, can we make it dynamic based on the version? git-lfs-windows-amd64-{#MyAppVersion}.exe. Also, does the version need 4 digits? If we can get away with a MyAppVersion of x.x.x, I think I'd prefer that.
There was a problem hiding this comment.
Yep should be easy to do.
…spects existing naming conventions. Set the existing version number to 3 digits instead of 4.
| ExpandConstant('{cmd}'), | ||
| '/C "for %i in (git.exe) do @echo. %~$PATH:i > "' + TmpFileName + '"', | ||
| '', SW_HIDE, ewWaitUntilTerminated, ResultCode | ||
| ); |
There was a problem hiding this comment.
This is problematic because git installers typically setup an alternate shell shortcut, like "Git CMD". But the default %PATH% will not have Git anywhere. Not sure what we can do about that though.
FWIW the shortcut is just "C:\Program Files\Git\git-cmd.exe" --cd-to-home.
|
What do you think about a step that asks for your Git For Windows installation dir? From what I can tell, we'd have to put
I don't really care about supporting GitHub Desktop or Sourcetree, since both bundle git lfs with their own bundled versions of Git. Having an input so people can add whatever path they want is important, but I also would like to support the standard Git For Windows installer too. |
|
This installer does already have a step where the user can optionally change the install directory. We simply try to find it for them and make it the default directory. In my tests only 1 directory requires the lfs executable - |
…rk, the old Git LFS must be uninstalled - This installer will attempt to do this for you silently. Added support for compiling x86 and x64 binaries into a single 32bit installer.
|
As per the commit comments, the installer will now install LFS into its own program dir in program files. It will compile both x86 and x64 binaries into a single installer and install the correct one based on the OS arch. Note that to allow the move to the new file location, we cannoy simply have the LFS dir at the start of the PATH env var as Git will choose to use the |
|
Cool, worked great for me 🤘 Thanks so much for hacking on this! |
|
#799 is still open, and according to my observation this is correct (the installer does not update the config files). Yet this is mentioned in the description and this is merged. Something went wrong here! |
|
Is this a system vs global issue, as you mentioned in #799 (comment) ? The installer should be running the command here. |
|
@dg9ngf: The problem is just that git lfs is not installing to something in |
|
Sounds reasonable. I just can't see this as a regular user of the installer. I've subscribed to the other issue. BTW, I didn't change the default install path, so this should hit everybody. |
In PR git-lfs#875 in 2016 the Windows installer was changed from NSIS to Inno Setup, and so logic was added in commit 1651e55 to silently try to run the old NSIS git-lfs-uninstaller.exe binary if it existed in the same directory as git.exe, as found using the normal PATH environment variables. As all users of Git LFS should have upgraded to a recent version installed with the Inno Setup installer, we can simply drop this additional logic along with the GetExistingGitInstallation() function of which it was the sole caller. Co-authored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
A new INNO Setup based windows installer. Features:
Should also fix: