Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toughen ruff linting #31

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Toughen ruff linting #31

merged 7 commits into from
Feb 6, 2024

Commits on Feb 6, 2024

  1. ruff . --select COM --fix

    @tony
    tony committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7ff97ab View commit details
    Browse the repository at this point in the history

  2. ruff format (after adding flake8-commas)

    @tony
    tony committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9e459d2 View commit details
    Browse the repository at this point in the history

  3. pyproject(ruff): Add flake8-commas, ignore COM812 for ruff format 

    See also:
- https://docs.astral.sh/ruff/rules/#flake8-commas-com
- https://pypi.org/project/flake8-commas/

Ignoring COM812:
- https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules
- https://docs.astral.sh/ruff/rules/missing-trailing-comma/
    @tony
    tony committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c578a52 View commit details
    Browse the repository at this point in the history

  4. pyproject(ruff): flake8-builtins 

    See also:
- https://docs.astral.sh/ruff/rules/#flake8-builtins-a
- https://pypi.org/project/flake8-builtins/
    @tony
    tony committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bb10bc0 View commit details
    Browse the repository at this point in the history

  5. fix!: Fix shadowing of python builtins 

    docs/conf.py:55:1: A001 Variable `copyright` is shadowing a Python builtin
src/doctest_docutils.py:378:13: A002 Argument `object` is shadowing a Python builtin
src/doctest_docutils.py:388:17: A001 Variable `object` is shadowing a Python builtin
Found 3 errors.
    @tony
    tony committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e1d6863 View commit details
    Browse the repository at this point in the history

  6. pyproject(ruff): Add flake8-errmsg 

    See also:
- https://docs.astral.sh/ruff/rules/#flake8-errmsg-em
- https://pypi.org/project/flake8-errmsg/
    @tony
    tony committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f46279c View commit details
    Browse the repository at this point in the history

  7. docs(CHANGES): Note linting improvements

    @tony
    tony committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    79a4ce2 View commit details
    Browse the repository at this point in the history