Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do the chocolatey stuff #340

Merged
merged 6 commits into from
Apr 11, 2013
Merged

Do the chocolatey stuff #340

merged 6 commits into from
Apr 11, 2013

Conversation

spraints
Copy link
Member

@spraints spraints commented Apr 1, 2013

This adds some automation around building the chocolatey package.

Open questions:

  • does anyone else want to be listed under Owners or Authors on the package?
  • does this need an uninstall script?

@pmiossec
Copy link
Member

pmiossec commented Apr 2, 2013

Well done.
Did approximately the same things some days ago and know that I should have found time to push before easter break to prevent work in double :(
Your solution seems good. Especially, if you succeed in making the chocolatey package ;)
Nevertheless, I will test it in the next days to produce the package to see if there is something to improve but seems good to me!

@spraints
Copy link
Member Author

spraints commented Apr 2, 2013

🆒 Let me know what you find. I've already made two packages with this. 😉

@pmiossec
Copy link
Member

Not found the time to test it :(
But it should be OK if you did 2 packages with that ;) Why not merge?

@spraints
Copy link
Member Author

No problem. It wasn't pressing, so I thought I'd wait to see if you had feedback. Merging now...

spraints added a commit that referenced this pull request Apr 11, 2013
@spraints spraints merged commit 20f9381 into master Apr 11, 2013
@spraints spraints deleted the chocolatey branch April 11, 2013 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants