#875 - Gated check-in in batch could possibly give a build failed

[tverboon]

When multiple shelvesets are validated in a batch, it possible that some shelveset didn't pass. The overall build status is Partially Succeeded. To find out if the requested build has been rejected or not, lookup this build in the request builds collection and check the status.

[tverboon]

I see that Vs2010 build is broken, this is because MS changed the interface IQueuedBuild. The Builds property is not available in 2010. Any ideas how to circumvent this? Don't really like it, but we could do a conditional build. Something like #if VS2010?

[tverboon]

Sorry, I messed up my commit message. It should beVS2010 of course

[spraints]

I see that Vs2010 build is broken, this is because MS changed the interface IQueuedBuild. The Builds property is not available in 2010. Any ideas how to circumvent this? Don't really like it, but we could do a conditional build. Something like #if VS2010?

I'm allergic to #if 😀 so I think something different should be done. The way we've dealt with it before is to have different code in the different VsXX projects. Almost all of it is shared in the TfsHelper.Common.cs file, but something like this could go into TfsHelper.Vs2012Base.cs. Since it's just a small piece of QueueGatedCheckinBuild, the new code could get pulled into a protected virtual method that's empty in TfsHelper.Common.cs and that has the new implementation in Vs2012Base.

[tverboon]

I'm allergic to #if

Me too! Will see if I can implement your proposal tomorrow

[tverboon]

Should be working now. I was trying to clean up the pull request, but my lack of experience only made it worse.

[tverboon]

Is it possible to retry a build, cause it failed on installation of nuget package?

[pmiossec]

Done.

[pmiossec]

I'm sorry to have to tell you, but even if the contribution seems very good (!), you end up with an history that is really a mess....... :(

Could you squash the history to keep only one commit?

Should be done with git rebase -i 74b7eec6526c5df6b0ea6168fd9a4240d629e8ef.
Then squash all the commits into the first one...

Then you will just have to force push.

[spraints]

Thanks for the contribution, and for squashing it!

[tverboon]

Your welcome, thanks for the feedback