Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition when browser opens before web server is ready #673

Closed
joglr opened this issue Nov 8, 2023 · 0 comments · Fixed by #674
Closed

Race condition when browser opens before web server is ready #673

joglr opened this issue Nov 8, 2023 · 0 comments · Fixed by #674
Assignees
@joglr
Labels
bug Something isn't working

Comments

@joglr
Copy link
Contributor

joglr commented Nov 8, 2023 •
edited

when running: npx git-truck@0.0.0-9ac4b13 i see the following in the browser:

image

while this is what I see in the terminal:

image

I suspect this issue to be introduced after upgrading Remix in #656

With Remix >2.0.0, we are no longer able to know when the web server is ready, as they removed an undocumented API that we relied on, so this might be a race condition issue with the web server not being ready yet. We will have to migrate to a custom web server to fix this issue, or experiment with the new vite integration from Remix.

Originally posted by @joglr in #662 (comment)
@joglr joglr mentioned this issue Nov 8, 2023
Open
@joglr joglr self-assigned this Nov 10, 2023
joglr added a commit that referenced this issue Nov 10, 2023
@joglr
Fix race condition when browser opens prematurely
088b701 
Fixes #673

See this breaking change from Remix for context:
remix-run/remix#7229
@joglr joglr mentioned this issue Nov 10, 2023
Merged
@joglr joglr added the bug Something isn't working label Nov 10, 2023
joglr added a commit that referenced this issue Nov 12, 2023
@joglr
Fix race condition when browser opens prematurely
2a22d8b 
Fixes #673

See this breaking change from Remix for context:
remix-run/remix#7229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joglr joglr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix race condition when browser opens before application is ready git-truck/git-truck
1 participant
@joglr