Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition when browser opens before application is ready #674

Merged

Conversation

joglr
Copy link
Contributor

@joglr joglr commented Nov 10, 2023

Fixes #673

See if you can reproduce the issue with: npx -y git-truck@0.0.0-088b701

The issue occured in this release: npx -y git-truck@0.0.0-d21ce66

Fixes #673

See this breaking change from Remix for context:
remix-run/remix#7229
@joglr joglr marked this pull request as ready for review November 10, 2023 00:52
@joglr joglr merged commit 2a22d8b into main Nov 12, 2023
4 checks passed
@joglr joglr deleted the 673/Race-condition-when-browser-opens-before-web-server-is-ready branch November 12, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition when browser opens before web server is ready
1 participant