Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list credential helpers #1786

Merged
merged 5 commits into from
Jun 19, 2023
Merged

list credential helpers #1786

merged 5 commits into from
Jun 19, 2023

Conversation

hickford
Copy link
Contributor

@hickford hickford commented May 29, 2023

New page listing available credential helpers

The aim of this change is to introduce a discoverable, helpful, community-maintained, comprehensive list of credential helpers. Questions about Git credentials such as https://stackoverflow.com/questions/35942754/how-can-i-save-username-and-password-in-git (3.5m views) are among the most viewed questions on StackOverflow. Users are desperate for information about credential helpers, but the Git docs only discuss credential-cache and credential-store

see discussion with @ldennington @peff @ttaylorr at https://lore.kernel.org/git/CAGJzqskaM80+8+79yUf435tP93Sk8sFu7marCvyimE=2gOKnog@mail.gmail.com/T/#m825e5fe599f14efa020e31d01864529f7bbd02ee

@hickford hickford marked this pull request as ready for review May 29, 2023 09:44
@hickford hickford force-pushed the credential-helpers branch 3 times, most recently from 5469461 to 687605f Compare May 29, 2023 19:41
app/views/doc/credential_helpers.html.erb Outdated Show resolved Hide resolved
app/views/doc/credential_helpers.html.erb Outdated Show resolved Hide resolved
app/views/shared/_sidebar.html.erb Outdated Show resolved Hide resolved
hickford and others added 2 commits June 6, 2023 06:42
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
@hickford hickford requested a review from ttaylorr June 6, 2023 07:49
Copy link
Contributor

@ldennington ldennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this - I think it'll be especially helpful to folks who are just getting started or are curious about what else is out there. Added a few minor suggestions, but my local testing looked good overall.

app/views/doc/credential_helpers.html.erb Outdated Show resolved Hide resolved
app/views/doc/credential_helpers.html.erb Outdated Show resolved Hide resolved
app/views/doc/credential_helpers.html.erb Outdated Show resolved Hide resolved
app/views/doc/credential_helpers.html.erb Outdated Show resolved Hide resolved
app/views/doc/credential_helpers.html.erb Outdated Show resolved Hide resolved
app/views/doc/credential_helpers.html.erb Outdated Show resolved Hide resolved
app/views/shared/_sidebar.html.erb Outdated Show resolved Hide resolved
ldennington

This comment was marked as duplicate.

Co-authored-by: Lessley Dennington <ldennington@github.com>
@hickford hickford force-pushed the credential-helpers branch 7 times, most recently from a78302b to 6e8fbbb Compare June 8, 2023 08:21
Copy link
Contributor

@ldennington ldennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look great to me - however, I'm not able to approve so will look to @ttaylorr to do so.

@hickford
Copy link
Contributor Author

@ttaylorr @peff any thoughts?

@ttaylorr
Copy link
Member

@ttaylorr @peff any thoughts?

I think that the credential helper page does not need to appear in the site sidebar.

@hickford
Copy link
Contributor Author

I think that the credential helper page does not need to appear in the site sidebar.

Change to sidebar already reverted, unless I'm missing something.

@ttaylorr
Copy link
Member

Change to sidebar already reverted, unless I'm missing something.

Ah, sorry, I must have misread the diff here. This LGTM.

@ttaylorr ttaylorr merged commit 036f27d into git:main Jun 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants