Skip to content

Commit

Permalink
merge-ort: handle D/F conflict where directory disappears due to merge
Browse files Browse the repository at this point in the history
When one side has a directory at a given path and the other side of
history has a file at the path, but the merge resolves the directory
away (e.g. because no path within that directory was modified and the
other side deleted it, or because renaming moved all the files
elsewhere), then we don't actually have a conflict anymore.  We just
need to clear away any information related to the relevant directory,
and then the subsequent process_entry() handling can handle the given
path.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
newren authored and gitster committed Jan 4, 2021
1 parent c5a6f65 commit 0ccfa4e
Showing 1 changed file with 22 additions and 1 deletion.
23 changes: 22 additions & 1 deletion merge-ort.c
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,28 @@ static void process_entry(struct merge_options *opt,
assert(ci->df_conflict);
}

if (ci->df_conflict) {
if (ci->df_conflict && ci->merged.result.mode == 0) {
int i;

/*
* directory no longer in the way, but we do have a file we
* need to place here so we need to clean away the "directory
* merges to nothing" result.
*/
ci->df_conflict = 0;
assert(ci->filemask != 0);
ci->merged.clean = 0;
ci->merged.is_null = 0;
/* and we want to zero out any directory-related entries */
ci->match_mask = (ci->match_mask & ~ci->dirmask);
ci->dirmask = 0;
for (i = MERGE_BASE; i <= MERGE_SIDE2; i++) {
if (ci->filemask & (1 << i))
continue;
ci->stages[i].mode = 0;
oidcpy(&ci->stages[i].oid, &null_oid);
}
} else if (ci->df_conflict && ci->merged.result.mode != 0) {
die("Not yet implemented.");
}

Expand Down

0 comments on commit 0ccfa4e

Please sign in to comment.