Skip to content

Commit

Permalink
Merge branch 'jc/upload-corrupt' into next
Browse files Browse the repository at this point in the history
* jc/upload-corrupt:
  upload-pack/fetch-pack: support side-band communication
  Retire git-clone-pack
  upload-pack: prepare for sideband message support.
  upload-pack: avoid sending an incomplete pack upon failure
  Fix possible out-of-bounds array access
  • Loading branch information
Junio C Hamano committed Jun 21, 2006
2 parents 4840122 + 583b7ea commit 3bec0da
Show file tree
Hide file tree
Showing 17 changed files with 342 additions and 296 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ git-cherry
git-cherry-pick
git-clean
git-clone
git-clone-pack
git-commit
git-commit-tree
git-convert-objects
Expand Down
64 changes: 0 additions & 64 deletions Documentation/git-clone-pack.txt

This file was deleted.

4 changes: 2 additions & 2 deletions Documentation/git-clone.txt
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ OPTIONS
--quiet::
-q::
Operate quietly. This flag is passed to "rsync" and
"git-clone-pack" commands when given.
"git-fetch-pack" commands when given.

-n::
No checkout of HEAD is performed after the clone is complete.
Expand All @@ -85,7 +85,7 @@ OPTIONS
--upload-pack <upload-pack>::
-u <upload-pack>::
When given, and the repository to clone from is handled
by 'git-clone-pack', '--exec=<upload-pack>' is passed to
by 'git-fetch-pack', '--exec=<upload-pack>' is passed to
the command to specify non-default path for the command
run on the other end.

Expand Down
3 changes: 1 addition & 2 deletions Documentation/git-receive-pack.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ information fed from the remote end.
This command is usually not invoked directly by the end user.
The UI for the protocol is on the 'git-send-pack' side, and the
program pair is meant to be used to push updates to remote
repository. For pull operations, see 'git-fetch-pack' and
'git-clone-pack'.
repository. For pull operations, see 'git-fetch-pack'.

The command allows for creation and fast forwarding of sha1 refs
(heads/tags) on the remote end (strictly speaking, it is the
Expand Down
2 changes: 1 addition & 1 deletion Documentation/git-upload-pack.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ SYNOPSIS

DESCRIPTION
-----------
Invoked by 'git-clone-pack' and/or 'git-fetch-pack', learns what
Invoked by 'git-fetch-pack', learns what
objects the other side is missing, and sends them after packing.

This command is usually not invoked directly by the end user.
Expand Down
6 changes: 1 addition & 5 deletions Documentation/git.txt
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ the working tree.
Synching repositories
~~~~~~~~~~~~~~~~~~~~~

gitlink:git-clone-pack[1]::
Clones a repository into the current repository (engine
for ssh and local transport).

gitlink:git-fetch-pack[1]::
Updates from a remote repository (engine for ssh and
local transport).
Expand Down Expand Up @@ -237,7 +233,7 @@ gitlink:git-update-server-info[1]::
clients discover references and packs on it.

gitlink:git-upload-pack[1]::
Invoked by 'git-clone-pack' and 'git-fetch-pack' to push
Invoked by 'git-fetch-pack' to push
what are asked for.

gitlink:git-upload-tar[1]::
Expand Down
2 changes: 1 addition & 1 deletion INSTALL
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Issues of note:

$ mkdir manual && cd manual
$ git init-db
$ git clone-pack git://git.kernel.org/pub/scm/git/git.git man html |
$ git fetch-pack git://git.kernel.org/pub/scm/git/git.git man html |
while read a b
do
echo $a >.git/$b
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ SIMPLE_PROGRAMS = \

# ... and all the rest that could be moved out of bindir to gitexecdir
PROGRAMS = \
git-checkout-index$X git-clone-pack$X \
git-checkout-index$X \
git-convert-objects$X git-fetch-pack$X git-fsck-objects$X \
git-hash-object$X git-index-pack$X git-local-fetch$X \
git-merge-base$X \
Expand Down
9 changes: 5 additions & 4 deletions builtin-grep.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ static int pathspec_matches(const char **paths, const char *name)
int matchlen = strlen(match);
const char *cp, *meta;

if ((matchlen <= namelen) &&
!strncmp(name, match, matchlen) &&
(match[matchlen-1] == '/' ||
name[matchlen] == '\0' || name[matchlen] == '/'))
if (!matchlen ||
((matchlen <= namelen) &&
!strncmp(name, match, matchlen) &&
(match[matchlen-1] == '/' ||
name[matchlen] == '\0' || name[matchlen] == '/')))
return 1;
if (!fnmatch(match, name, 0))
return 1;
Expand Down
4 changes: 2 additions & 2 deletions cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,8 @@ extern char git_commit_encoding[MAX_ENCODING_LENGTH];
extern int copy_fd(int ifd, int ofd);

/* Finish off pack transfer receiving end */
extern int receive_unpack_pack(int fd[2], const char *me, int quiet);
extern int receive_keep_pack(int fd[2], const char *me, int quiet);
extern int receive_unpack_pack(int fd[2], const char *me, int quiet, int);
extern int receive_keep_pack(int fd[2], const char *me, int quiet, int);

/* pager.c */
extern void setup_pager(void);
Expand Down
186 changes: 0 additions & 186 deletions clone-pack.c

This file was deleted.

Loading

0 comments on commit 3bec0da

Please sign in to comment.