Skip to content

Commit

Permalink
git-gui: Allow 'git gui version' outside of a repository
Browse files Browse the repository at this point in the history
I got a little surprise one day when I tried to run 'git gui version'
outside of a Git repository to determine what version of git-gui was
installed on that system.  Turns out we were doing the repository
check long before we got around to command line argument handling.

We now look to see if the only argument we have been given is
'version' or '--version', and if so, print out the version and
exit immediately; long before we consider looking at the Git
version or working directory.  This way users can still get to
the git-gui version number even if Git's version cannot be read.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
spearce committed Mar 12, 2007
1 parent bb616dd commit 756d846
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions git-gui.sh
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,11 @@ proc ask_popup {msg} {
##
## version check

if {{--version} eq $argv || {version} eq $argv} {
puts "git-gui version $appvers"
exit
}

set req_maj 1
set req_min 5

Expand Down Expand Up @@ -5054,8 +5059,6 @@ enable_option branch
enable_option transport

switch -- $subcommand {
--version -
version -
browser -
blame {
disable_option multicommit
Expand Down Expand Up @@ -5426,11 +5429,6 @@ bind all <$M1B-Key-W> {destroy [winfo toplevel %W]}
# -- Not a normal commit type invocation? Do that instead!
#
switch -- $subcommand {
--version -
version {
puts "git-gui version $appvers"
exit
}
browser {
if {[llength $argv] != 1} {
puts stderr "usage: $argv0 browser commit"
Expand Down

0 comments on commit 756d846

Please sign in to comment.