Browse files

Stop starting pager recursively

git-column can be used as a pager for other git commands, something
like this:

    GIT_PAGER="git -p column --mode='dense color'" git -p branch

The problem with this is that "git -p column" also has $GIT_PAGER set so
the pager runs itself again as another pager. The end result is an
infinite loop of forking. Other git commands have the same problem if
being abused this way.

Check if $GIT_PAGER is already set and stop launching another pager.

Signed-off-by: Nguyễn Thái Ngọc Duy <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent 7e29b82 commit 88e8f908f2b0c56f9ccf8134d8ff9f689af9cc84 @pclouds pclouds committed with gitster Apr 13, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 pager.c
@@ -73,7 +73,7 @@ void setup_pager(void)
const char *pager = git_pager(isatty(1));
- if (!pager)
+ if (!pager || pager_in_use())

0 comments on commit 88e8f90

Please sign in to comment.