Skip to content

Commit

Permalink
builtin/log: remove redundant initialization
Browse files Browse the repository at this point in the history
"abbrev" and "commit_format" in struct rev_info get initialized in
init_revisions - no need to reinit in cmd_log_init_defaults.

Signed-off-by: Michael Schubert <mschub@elegosoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Michael Schubert authored and gitster committed Dec 21, 2011
1 parent f1f509c commit 967cf98
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions builtin/log.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ static int decorate_callback(const struct option *opt, const char *arg, int unse

static void cmd_log_init_defaults(struct rev_info *rev)
{
rev->abbrev = DEFAULT_ABBREV;
rev->commit_format = CMIT_FMT_DEFAULT;
if (fmt_pretty)
get_commit_format(fmt_pretty, rev);
rev->verbose_header = 1;
Expand Down

0 comments on commit 967cf98

Please sign in to comment.