Skip to content

Commit

Permalink
t5580: test cloning without file://, test fetching via UNC paths
Browse files Browse the repository at this point in the history
On Windows, it is quite common to work with network drives. The format
of the paths to network drives (or "network shares", or UNC paths) is:

	\\<server>\<share>\...

We already have a couple regression tests revolving around those types
of paths, but we missed cloning and fetching from UNC paths without
leading `file://` (and with backslashes instead of forward slashes).
This lil' patch closes that gap.

It gets a bit silly to add the commands to the name of the test script,
so let's just rename it while we're testing more UNC stuff.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
dscho authored and gitster committed Feb 14, 2020
1 parent b6d4d82 commit bfe2bbb
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions t/t5580-clone-push-unc.sh → t/t5580-unc-paths.sh
Expand Up @@ -40,11 +40,23 @@ test_expect_success clone '
git clone "file://$UNCPATH" clone
'

test_expect_success 'clone without file://' '
git clone "$UNCPATH" clone-without-file
'

test_expect_success 'clone with backslashed path' '
BACKSLASHED="$(echo "$UNCPATH" | tr / \\\\)" &&
git clone "$BACKSLASHED" backslashed
'

test_expect_success fetch '
git init to-fetch &&
(
cd to-fetch &&
git fetch "$UNCPATH" master
)
'

test_expect_success push '
(
cd clone &&
Expand Down

0 comments on commit bfe2bbb

Please sign in to comment.