Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtin/rebase: remove a redundant space in l10n string #1277

Closed
wants to merge 1 commit into from

Conversation

fangyi-zhou
Copy link
Contributor

@fangyi-zhou fangyi-zhou commented Jun 16, 2022

Found in l10n.

Signed-off-by: Fangyi Zhou me@fangyi.io

Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list (git@vger.kernel.org) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.

Please read the "guidelines for contributing" linked above!

cc: Philip Oakley philipoakley@iee.email

Found in l10n.

Signed-off-by: Fangyi Zhou <me@fangyi.io>
@fangyi-zhou
Copy link
Contributor Author

/submit

@gitgitgadget-git
Copy link

Submitted as pull.1277.git.git.1655399939066.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1277/fangyi-zhou/fix-rebase-extra-space-v1

To fetch this version to local tag pr-git-1277/fangyi-zhou/fix-rebase-extra-space-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1277/fangyi-zhou/fix-rebase-extra-space-v1

@gitgitgadget-git
Copy link

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Fangyi Zhou via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Fangyi Zhou <me@fangyi.io>
>
> Found in l10n.
>
> Signed-off-by: Fangyi Zhou <me@fangyi.io>

Thanks.

> -			"Note: Your `pull.rebase` configuration may also be  set to 'preserve',\n"
> +			"Note: Your `pull.rebase` configuration may also be set to 'preserve',\n"

@gitgitgadget-git
Copy link

Found multiple candidates in gitster.git:
refs/remotes/gitster/main
refs/remotes/gitster/master;

Using the first one.

@gitgitgadget-git
Copy link

This branch is now known as main.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 3b9a5a3.

@gitgitgadget-git
Copy link

This patch series was integrated into next via 10f37be.

@gitgitgadget-git
Copy link

Found multiple candidates in gitster.git:
refs/remotes/gitster/main
refs/remotes/gitster/master;

Using the first one.

1 similar comment
@gitgitgadget-git
Copy link

Found multiple candidates in gitster.git:
refs/remotes/gitster/main
refs/remotes/gitster/master;

Using the first one.

@gitgitgadget-git
Copy link

On the Git mailing list, Philip Oakley wrote (reply to this):

On 16/06/2022 19:15, Junio C Hamano wrote:
> "Fangyi Zhou via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Fangyi Zhou <me@fangyi.io>
>>
>> Found in l10n.
>>
>> Signed-off-by: Fangyi Zhou <me@fangyi.io>
> Thanks.
>
>> -			"Note: Your `pull.rebase` configuration may also be  set to 'preserve',\n"
>> +			"Note: Your `pull.rebase` configuration may also be set to 'preserve',\n"
That was my error. Sorry for not being able to respond at the time.
--
Philip

@gitgitgadget-git
Copy link

User Philip Oakley <philipoakley@iee.email> has been added to the cc: list.

@dscho dscho closed this Jun 17, 2022
@fangyi-zhou fangyi-zhou deleted the fix-rebase-extra-space branch June 17, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants