[OUTREACHY]cleaning t1002-read-tree-m-u-2way.sh

[nsengiyumva-wilberforce]

This is an update in t1002-read-tree-m-u-2way.sh.
all the tests that use the unusual construct: if read_tree_u_must_succeed -m -u $treeH $treeM; then false; else :; fi have been updated to ! read_tree_u_must_succeed -m -u $treeH $treeM "I am an outreachy applicant"
CC: Christian Couder christian.couder@gmail.com, Hariom verma hariom18599@gmail.com
Signed-off-by: wilberforce nsengiyumvawilberforce@gmail.com

Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list (git@vger.kernel.org) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.

Please read the "guidelines for contributing" linked above!

cc: Derrick Stolee derrickstolee@github.com
cc: Eric Sunshine sunshine@sunshineco.com
cc: Philip Oakley philipoakley@iee.email

[gitgitgadget-git]

Welcome to GitGitGadget

Hi @nsengiyumva-wilberforce, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that your Pull Request has a good description, as it will be used as cover letter. You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <revi.ewer@example.com>, Ill Takalook <ill.takalook@example.net>

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

[gitgitgadget-git]

There are issues in commit 6b620de:
[OUTREACHY]cleaning t1002-read-tree-m-u-2way.sh
The first line must be separated from the rest by an empty line
Lines in the body of the commit messages should be wrapped between 60 and 76 characters.
Indented lines, and lines without whitespace, are exempt

[gitgitgadget-git]

There are issues in commit 6b620de:
[OUTREACHY]cleaning t1002-read-tree-m-u-2way.sh
The first line must be separated from the rest by an empty line
Lines in the body of the commit messages should be wrapped between 60 and 76 characters.
Indented lines, and lines without whitespace, are exempt

[dscho]

/allow

[gitgitgadget-git]

User nsengiyumva-wilberforce is now allowed to use GitGitGadget.

WARNING: nsengiyumva-wilberforce has no public email address set on GitHub;
GitGitGadget needs an email address to Cc: you on your contribution, so that you receive any feedback on the Git mailing list. Go to https://github.com/settings/profile to make your preferred email public to let GitGitGadget know which email address to use.

[nsengiyumva-wilberforce]

/submit

[gitgitgadget-git]

There are issues in commit 6b620de:
[OUTREACHY]cleaning t1002-read-tree-m-u-2way.sh
The first line must be separated from the rest by an empty line
Lines in the body of the commit messages should be wrapped between 60 and 76 characters.
Indented lines, and lines without whitespace, are exempt

[gitgitgadget-git]

There are issues in commit 8249f24:
[OUTREACHY] t1002: modernize outdated conditional
Lines in the body of the commit messages should be wrapped between 60 and 76 characters.
Indented lines, and lines without whitespace, are exempt

[sgn]

You can use this for your commit message (no, this is not very good msg either):

t1002: modernize outdated conditional

Tests in this script use an unusual and hard to reason about
conditional construct

    if expression; then false; else :; fi

Change them to use more idiomatic construct:

    ! expression

Cc: Christian Couder  <christian.couder@gmail.com>
Cc: Hariom Verma <hariom18599@gmail.com>
Signed-off-by: wilberforce <nsengiyumvawilberforce@gmail.com>

Also, please change Signed-off-by to your full name.

[gitgitgadget-git]

There are issues in commit a4e9c8a:
[OUTREACHY] t1002: modernize outdated conditional
Lines in the body of the commit messages should be wrapped between 60 and 76 characters.
Indented lines, and lines without whitespace, are exempt

[gitgitgadget-git]

There are issues in commit bbcd472:
[OUTREACHY] t1002: modernize outdated conditional
Commit not signed off

[gitgitgadget-git]

There are issues in commit eb58b24:
[OUTREACHY] t1002: modernize outdated conditional
Commit not signed off

[nsengiyumva-wilberforce]

/submit

[gitgitgadget-git]

Submitted as pull.1362.git.git.1665713184304.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1362/nsengiyumva-wilberforce/t1002_usual_construct_updated-v1

To fetch this version to local tag pr-git-1362/nsengiyumva-wilberforce/t1002_usual_construct_updated-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1362/nsengiyumva-wilberforce/t1002_usual_construct_updated-v1

[gitgitgadget-git]

On the Git mailing list, Junio C Hamano wrote (reply to this):

"nsengaw4c via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: wilberforce <nsengiyumvawilberforce@gmail.com>

This name must match ...

> Tests in this script use an unusual and hard to reason about
> conditional construct
>
>     if expression; then false; else :; fi
>
> Change them to use more idiomatic construct:
>
>     ! expression
>
> Cc: Christian Couder  <christian.couder@gmail.com>
> Cc: Hariom Verma <hariom18599@gmail.com>
> Signed-off-by: Nsengiyumva  wilberfore <nsengiyumvawilberforce@gmail.com>

... the name you sign-off your work with.

> -     if read_tree_u_must_succeed -m -u $treeH $treeM; then false; else :; fi'
> +     ! read_tree_u_must_succeed -m -u $treeH $treeM'

OK.

[nsengiyumva-wilberforce]

/preview

[gitgitgadget-git]

Preview email sent as pull.1362.v2.git.git.1665731863146.gitgitgadget@gmail.com

[nsengiyumva-wilberforce]

/preview

[gitgitgadget-git]

Preview email sent as pull.1362.v2.git.git.1665732866580.gitgitgadget@gmail.com

[nsengiyumva-wilberforce]

User name updated

[gitgitgadget-git]

User Philip Oakley <philipoakley@iee.email> has been added to the cc: list.

[gitgitgadget-git]

On the Git mailing list, Junio C Hamano wrote (reply to this):

Eric Sunshine <sunshine@sunshineco.com> writes:

> ... However, clarification about whether or not there needs to
> be a blank line before the CC: line would be nice (I presume the blank
> line is needed), but also whether or not GitGitGadget correctly deals
> with multiple people mentioned on the same CC: line or if they each
> need to occupy a single CC: line.

Indeed it is very good to have such a documentation that tells us
all these things.  Is the "Welcome to GGG" comment it adds to first
time users a good place to have this kind of information (I am
guessing not, as more advanced features may become needed after you
used the tool several times)?

[gitgitgadget-git]

On the Git mailing list, Junio C Hamano wrote (reply to this):

Philip Oakley <philipoakley@iee.email> writes:

> I just want to throw in that because GitHub takes the PR & comitts
> verbatim, but Git itself works via email, you can add description
> portions to commits, and I believe the PR part, by add a line containing
> just three dashes `---` followed by the additional descriptive note text
> which won't be used when `am` (apply mailbox) is used.

Yup, if you are absolutely sure you won't interact with others in
any way other than e-mailed patches, it is a great trick to use.

[gitgitgadget-git]

This patch series was integrated into seen via cb36e95.

[gitgitgadget-git]

This patch series was integrated into seen via b26ce98.

[gitgitgadget-git]

There was a status update in the "New Topics" section about the branch nw/t1002-cleanup on the Git mailing list:

source: <pull.1362.v3.git.git.1665734502591.gitgitgadget@gmail.com>

[nsengiyumva-wilberforce]

What if read-tree segfaults? This entire function will fail and the test that runs read_tree_u_must_succeed and negates its result would be a poor fit here. hi, I am currently looking at this issue, I would like to have some hints

about this in case there are some. Thanks, Wilberforce thanks, wilberforce

…

On Fri, Oct 14, 2022 at 7:20 PM gitgitgadget-git[bot] < ***@***.***> wrote: On the Git mailing list ***@***.***>, Junio C Hamano wrote (reply to this <https://github.com/gitgitgadget/gitgitgadget/wiki/ReplyToThis>): "nsengaw4c via GitGitGadget" ***@***.***> writes: > From: Nsengiyumva Wilberforce ***@***.***>>> Tests in this script use an unusual and hard to reason about> conditional construct>> if expression; then false; else :; fi>> Change them to use more idiomatic construct:>> ! expression>> Cc: Christian Couder ***@***.***>> Cc: Hariom Verma ***@***.***>> Signed-off-by: Nsengiyumva Wilberforce ***@***.***> What are these C: lines for? I do not think the message I am responding to is Cc'ed to them. There may be a special incantation to tell GitGitGadget to Cc to certain folks, but adding Cc: to the log message trailer like this does not seem to be it---at least it appears that it did not work that way. > ...> - if read_tree_u_must_succeed -m -u $treeH $treeM; then false; else :; fi'> + ! read_tree_u_must_succeed -m -u $treeH $treeM' Looks good. For the purpose of microproject, I think this is a good place to stop, as it does not make anything worse and make the code prettier. To those more experienced contributors who are watching from sidelines, and especially to our mentors, it may be worth taking a look at the implementation of the helper shell function used here, and think if it makes sense to expect a failure with a simple "!" prefix (or with the original long hand if/then/else/fi that has exactly the same issue). read_tree_u_must_succeed () { git ls-files -s >pre-dry-run && git diff-files -p >pre-dry-run-wt && git read-tree -n "$@" && git ls-files -s >post-dry-run && git diff-files -p >post-dry-run-wt && test_cmp pre-dry-run post-dry-run && test_cmp pre-dry-run-wt post-dry-run-wt && git read-tree "$@" } What if read-tree segfaults? This entire function will fail and the test that runs read_tree_u_must_succeed and negates its result would be a poor fit here. Thanks. — Reply to this email directly, view it on GitHub <#1362 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APW5Y2NYQYCLETJSDF4KM3DWDGB4LANCNFSM6AAAAAARENKDUU> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[dscho]

What if read-tree segfaults? This entire function will fail and the test that runs read_tree_u_must_succeed and negates its result would be a poor fit here. hi, I am currently looking at this issue, I would like to have some hints

about this in case there are some.

Thanks,
Wilberforce
thanks,
wilberforce

@nsengiyumva-wilberforce unfortunately, it is not as easy as replying to the notification mail sent by GitHub.

You will have to follow the instructions given at the top of #1362 (comment): Read the guidance at https://github.com/gitgitgadget/gitgitgadget/wiki/ReplyToThis and then reply to https://lore.kernel.org/git/xmqqv8om9yaz.fsf@gitster.g

[gitgitgadget-git]

This patch series was integrated into seen via abeef79.

[gitgitgadget-git]

This patch series was integrated into seen via 77d6258.

[gitgitgadget-git]

There was a status update in the "Cooking" section about the branch nw/t1002-cleanup on the Git mailing list:

Code clean-up in test.

Will merge to 'next'.
source: <pull.1362.v3.git.git.1665734502591.gitgitgadget@gmail.com>

[gitgitgadget-git]

There was a status update in the "Cooking" section about the branch nw/t1002-cleanup on the Git mailing list:

Code clean-up in test.

Will merge to 'next'.
source: <pull.1362.v3.git.git.1665734502591.gitgitgadget@gmail.com>

[gitgitgadget-git]

This patch series was integrated into seen via 766dc81.

[gitgitgadget-git]

This patch series was integrated into next via e6ae742.

[gitgitgadget-git]

This patch series was integrated into seen via a4df096.

[gitgitgadget-git]

This patch series was integrated into seen via 3432f98.

[gitgitgadget-git]

This patch series was integrated into seen via 53537f9.

[gitgitgadget-git]

This patch series was integrated into seen via 34d177c.

[gitgitgadget-git]

This patch series was integrated into seen via ba1672c.

[gitgitgadget-git]

This patch series was integrated into seen via dc6c483.

[gitgitgadget-git]

There was a status update in the "Cooking" section about the branch nw/t1002-cleanup on the Git mailing list:

Code clean-up in test.

Will merge to 'master'.
source: <pull.1362.v3.git.git.1665734502591.gitgitgadget@gmail.com>

[gitgitgadget-git]

This patch series was integrated into seen via 702bb4b.

[gitgitgadget-git]

This patch series was integrated into master via 702bb4b.

[gitgitgadget-git]

This patch series was integrated into next via 702bb4b.

[gitgitgadget-git]

Closed via 702bb4b.