Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitsubmodules: add '--recurse-submodules' for 'ls-files' #861

Closed
wants to merge 1 commit into from
Closed

gitsubmodules: add '--recurse-submodules' for 'ls-files' #861

wants to merge 1 commit into from

Conversation

phil-blain
Copy link
Contributor

No description provided.

@phil-blain
gitsubmodules: add '--recurse-submodules' for 'ls-files'
0c05b3c 
`git ls-files` was never taught to respect the `submodule.recurse`
configuration variable, and it seems it is too late now to change that
[1], but still the command is mentioned in 'gitsubmodules(7)' as if it
does respect that config.

Adjust the call in 'gitsubmodules(7)' by adding the
'--recurse-submodules' flag.

While at it, uniformize the capitalization in that file, and use
backticks instead of quotes for Git commands and configuration
variables.

[1] https://lore.kernel.org/git/pull.732.git.1599707259907.gitgitgadget@gmail.com/T/#u

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
@phil-blain
Copy link
Contributor Author

/submit

@gitgitgadget-git
Copy link

Submitted as pull.861.git.git.1601774257696.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git pr-git-861/phil-blain/gitsubmodules-ls-files-v1

To fetch this version to local tag pr-git-861/phil-blain/gitsubmodules-ls-files-v1:

git fetch --no-tags https://github.com/gitgitgadget/git tag pr-git-861/phil-blain/gitsubmodules-ls-files-v1

@gitgitgadget-git
Copy link

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:

> @@ -246,20 +246,23 @@ Workflow for an artificially split repo
>    # regular commands recurse into submodules by default
>    git config --global submodule.recurse true
>  
> -  # Unlike the other commands below clone still needs
> +  # Unlike most other commands below, clone still needs
>    # its own recurse flag:
>    git clone --recurse <URL> <directory>
>    cd <directory>
>  
>    # Get to know the code:
>    git grep foo
> -  git ls-files
> +  git ls-files --recurse-submodules
> +
> +[NOTE]
> +`git ls-files` also requires its own `--recurse-submodules` flag.

Makes sense.  Thanks, will queue.

@gitgitgadget-git
Copy link

This branch is now known as pb/submodule-doc-fix.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via fa90c08.

@gitgitgadget-git gitgitgadget-git bot added the seen label Oct 4, 2020
@gitgitgadget-git
Copy link

This patch series was integrated into seen via 371f449.

@gitgitgadget-git
Copy link

This patch series was integrated into next via c535486.

@gitgitgadget-git gitgitgadget-git bot added the next label Oct 4, 2020
@gitgitgadget-git
Copy link

This patch series was integrated into seen via 9d19e17.

@gitgitgadget-git
Copy link

This patch series was integrated into next via 9d19e17.

@gitgitgadget-git
Copy link

This patch series was integrated into master via 9d19e17.

@gitgitgadget-git gitgitgadget-git bot closed this Oct 5, 2020
@gitgitgadget-git
Copy link

Closed via 9d19e17.

@phil-blain phil-blain deleted the gitsubmodules-ls-files branch August 17, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master next seen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phil-blain