New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(comment) comments via email notification #227
Conversation
Github sends emails to users who are subscribed to notifications. The Gitalk comment behavior should match that of Github. The previous behavior does not hide extended email replys. Often times the email response contains the complete email chain. The visible email chain confuses the user with unformatted html strings. Incorrect comment formatting for email replies. gitalk#224
Hi guys, |
edaee4c
to
e836f67
Compare
If you take a look at this issue, I opened a case with Github support about the json that appears in the html string. I'll let you know what they say. It might be that this work is unnecessary, if Github comes back and admits the json shouldn't be included in the html string. |
@garrettbryan Good job. Please don't commit the |
@booxood sorry for the delay. I've been focused on another project. Sorry about committing the dist directory. I'll clean it up and try again. |
@booxood I heard from GitHub support, they confirmed that comments via email should contain the extra json data, hidden by the button. |
@booxood one other question, How concerned are you with the tests? I haven't fully implemented the test cases. |
refactor email comment code to not use findDOMNode to register click listener. add test for extended email comment processing. Incorrect comment formatting for email replies. gitalk#224
e836f67
to
9886ffb
Compare
refactor email comment code to not use findDOMNode to register click listener. add test for extended email comment processing. Incorrect comment formatting for email replies. gitalk#224
I'm sorry about muddying up this pull request! |
Hi @garrettbryan, thanks for the great work. Do we have any progress on this issue? |
@garrettbryan Merged and little modified test case. 😌 |
I’ve not had time to fix the comments on my merge request.
…Sent from my iPhone
On Jan 31, 2020, at 4:53 AM, Draven ***@***.***> wrote:
Hi @garrettbryan, thanks for the great work. Do we have any progress on this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Github sends emails to users who are subscribed to
notifications. The Gitalk comment behavior should match that of
Github.
The previous behavior does not hide extended email replys.
Often times the email response contains the complete email
chain. The visible email chain confuses the user with
unformatted html strings.
Incorrect comment formatting for email replies. #224
Before submitting a pull request, please make sure the following is done: