Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(comment) comments via email notification #227

Closed
wants to merge 5 commits into from
Closed

fix(comment) comments via email notification #227

wants to merge 5 commits into from

Commits on Jan 30, 2019

  1. fix(comment) comments via email notification 

    Github sends emails to users who are subscribed to
notifications. The Gitalk comment behavior should match that of
Github.

The previous behavior does not hide extended email replys.
Often times the email response contains the complete email
chain. The visible email chain confuses the user with
unformatted html strings.

Incorrect comment formatting for email replies. gitalk#224
    @garrettbryan
    garrettbryan committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    9886ffb View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. test(comment) add test "extended" email comment 

    refactor email comment code to not use findDOMNode to register click
listener.

add test for extended email comment processing.

Incorrect comment formatting for email replies. gitalk#224
    @garrettbryan
    garrettbryan committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    7cf33e4 View commit details
    Browse the repository at this point in the history

  2. add test incomplete

    @garrettbryan
    garrettbryan committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    1a22ae2 View commit details
    Browse the repository at this point in the history

  3. test(comment) add test "extended" email comment 

    refactor email comment code to not use findDOMNode to register click
listener.

add test for extended email comment processing.

Incorrect comment formatting for email replies. gitalk#224
    @garrettbryan
    garrettbryan committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    3808685 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix-email-comments' into add-tests

    @garrettbryan
    garrettbryan committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    15565ab View commit details
    Browse the repository at this point in the history