Page Layout: Support hiding GridLines for exports #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gitbrent I wanted to know if you saw this. Please let me know if this is something you would like to be merged into the project, otherwise I will close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I wanted to add support for disabling gridlines when generating XLSX files. This isn't something SheetJs provides as part of the community edition (SheetJS#1945). I made the changes myself and wanted to see if you'd want to include them in this project.
Using this commit: SheetJS#927 as a reference point. I expanded the options to support disabling gridlines for exports. Initially, I was going to add this as a custom prop in the WritingOptions/SheetOptions, but ultimately wanted to remain aligned with the openxml schema and opted for another WBView boolean.
(https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.spreadsheet.sheetview?view=openxml-2.8.1)
Let me know if you have any feedback!