This repository has been archived by the owner on Aug 13, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
has conflicts
Assigned to pull requests that have conflicts with master
label
May 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #1310 +/- ##
==========================================
+ Coverage 34.76% 34.88% +0.12%
==========================================
Files 345 352 +7
Lines 7989 8104 +115
==========================================
+ Hits 2777 2827 +50
- Misses 5212 5277 +65
|
andrewmcodes
reviewed
Jun 9, 2020
const date = new Date(Date.parse(dateString)) // => Tue Jun 09 2020 14:33:59 GMT-0400 (EDT) | ||
let expiresAt = new Date() | ||
expiresAt.setTime(date.getTime()) | ||
const setAt = expiresAt.setDate(expiresAt.getDate() + this.daysToLive) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a look (and the comment can be removed) but I am pretty sure this is what we want. We may be able to make it a bit cleaner but this works.
andrewmcodes
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than those failing tests nothing is sticking out to me.
andrewmcodes
removed
has conflicts
Assigned to pull requests that have conflicts with master
in progress
This is actively being worked on
labels
Jun 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Description
https://jsbin.com/dawagiyeda/edit?html,console,output
Checklist
Screenshots