URL encoded collection data for grant rounds #1786

ghostffcode · 2023-05-11T16:28:57Z

Description

Considering the issue with Shilling grants on socials, we at Supermodular thought about a solution to share a collection of grants with peers.

The way this draft works is by storing the collection title, round id and list of projects in localStorage for easy customization, encode that collection data and append it to url search params for /collection?data=[encodedCollectionData]. Attached below is a demo video:

Grants Curation w/ URL Encoding - Watch Video

Refers/Fixes

N/A

Testing

This is an initial draft and we are hoping to get some feedback on it before proceeding.

…ctions Localstorage encoded collections

thelostone-mc

Haha nice work on this @ghostffcode.
Roping in product for validation
Few feedback :

remove custom fonts and just re-use hero-icon what tailwind comes with
could we add tests in for all of these functions
re add semicolon wherever it was removed

thelostone-mc · 2023-05-12T09:54:26Z

package.json

@@ -29,6 +29,7 @@
    "api-build": "turbo run build --filter=api",
    "api-test": "turbo run test --filter=api",
    "api-start": "pnpm --filter api run start",
+    "api-gen": "pnpm --filter api run prisma:generate",


Is this needed?

API folder is not used anymore so this might be just a leftover from git.

thelostone-mc · 2023-05-12T09:55:07Z

packages/grant-explorer/package.json

    "@wagmi/core": "0.5.4",
-    "allo-indexer-client": "github:gitcoinco/allo-indexer-client#48490969985125e89bf1d65725ef9e510c97256a",
+    "allo-indexer-client": "github:gitcoinco/allo-indexer-client#9e713f46db8a13e19c923a983bc5956b79da7c56",


Was this intentional updated . If not let's stick to the version that is on main

thelostone-mc · 2023-05-12T09:57:23Z

packages/grant-explorer/package.json

    "react-redux": "^8.0.1",
    "react-router": "^6",
    "react-router-dom": "6",
    "react-scripts": "5.0.1",
+    "react-select": "5.7.3",


would recommend using what we already have multiselect. Checkout the cart page

thelostone-mc · 2023-05-12T09:57:56Z

packages/grant-explorer/package.json

@@ -88,10 +93,12 @@
    "react-dom": "^18.1.0",
    "react-gtm-module": "^2.0.11",
    "react-hook-form": "^7.31.3",
+    "react-loading-spin": "^2.1.9",


We've got a spinner used across the app. Would recommend using that . Spinner.tsx is the file you are looking for

thelostone-mc · 2023-05-12T09:58:28Z

packages/grant-explorer/package.json

    "babel-loader": "^8.3.0",
    "buffer": "^6.0.3",
+    "classnames": "^2.3.2",


can be removed, we have a util function which does this already

Located in the common package to be clear.

thelostone-mc · 2023-05-12T10:02:23Z

packages/grant-explorer/src/features/api/round.ts


-    const round: RoundResult = res.data.rounds[0];
+    const round: RoundResult = res.data.rounds[0]


^ re-add the ; cause that's the formatting we stick to on the package

thelostone-mc · 2023-05-12T10:03:01Z

packages/grant-explorer/src/features/collection/AllCollections.tsx

+
+// function formatAddress(address: `0x${string}`): string {
+//   return `${address.slice(0, 6)}...${address.slice(-6)}`
+// }


remove this if not needed

thelostone-mc · 2023-05-12T10:03:49Z

packages/grant-explorer/src/features/collection/ViewCollection.tsx

+import { ProjectsWithRoundData, getProjects } from "../api/round";
+import { ReactComponent as ArrowUpRight } from "../../assets/icons/arrow-up-right.svg"
+import Navbar from "../common/Navbar";
+// import { useCart } from "../../context/CartContext";


let's remove this

thelostone-mc · 2023-05-12T10:04:22Z

packages/grant-explorer/src/features/discovery/LandingPage.tsx

@@ -12,7 +12,7 @@ import ApplyNowSection from "./ApplyNowSection";

 const LandingPage = () => {
  if (process.env.REACT_APP_ENV === "production") {
-    window.location.replace("https://grants.gitcoin.co");
+    // window.location.replace("https://grants.gitcoin.co");


could you add this back in please

thelostone-mc · 2023-05-12T10:04:44Z

packages/grant-explorer/src/features/round/ViewRoundPage.tsx

+
+function classNames(...classes: string[]) {
+  return classes.filter(Boolean).join(' ')
+}


^ I think we already have this in common package / utils

Yes, find it in common package.

owocki · 2023-05-12T15:01:04Z

hi from supermodular! here is a deployed version of this you can play with: https://grant-explorer.vercel.app/#/round/1/0x12bb5bbbfe596dbc489d209299b8302c3300fa40

kevinrolsen · 2023-05-12T15:56:28Z

Thanks! Amazing to have this PR come in.

Just noticed the collection count didn't increment after I created a collection.

melissa-neira · 2023-05-12T16:29:40Z

This is great, thank you so much! What's the best way to get some design input/collaboration going?

owocki · 2023-05-13T21:53:36Z

This is great, thank you so much! What's the best way to get some design input/collaboration going?

@melissa-neira At this point, Supermodular just wants a gut check that a PR/exploration of collection creation was welcome. If that is the case, then, we will continue investing resources into it. If so, pls DM me on discord (Owocki#1337) and we can setup a discord group to discuss.

btw @kevinrolsen fun collection name :)

gravityblast · 2023-05-18T16:02:45Z

I love this feature, thanks @ghostffcode @owocki great job!

meglister · 2023-05-18T22:04:27Z

i'll dm you on discord @owocki !

* star svg for lists * implement collections re-design * add isInCollection prop * clean up

vacekj · 2023-06-19T14:43:29Z

@ghostffcode Hey, are you still working on this? If yes, please use Prettier (pnpm format) to format the files before you submit. If you don't plan on working on this, we can take it over to bring it over the finish line. 🙌

Also converted to draft before it's ready for merge.

ghostffcode · 2023-06-20T16:04:18Z

@ghostffcode Hey, are you still working on this? If yes, please use Prettier (pnpm format) to format the files before you submit. If you don't plan on working on this, we can take it over to bring it over the finish line. 🙌

Also converted to draft before it's ready for merge.

Hey, thanks for this reminder. All the requested updates are in. I am open to having you take over and finishing it. Let me know if there's anything I can help with. Thanks again 🙏🏾

vacekj · 2023-11-23T17:01:21Z

@gitcoinco/grantsstack I beleive this can be closed as it's superseded by the current collection feature?

thelostone-mc · 2024-02-22T11:56:04Z

Closing this out as the PR is not longer applicable to the current feature

ghostffcode added 7 commits May 10, 2023 18:06

localstorage & urlencoding grants curation

2db0d21

Merge branch 'main' into localstorage-encoded-collections

d2401bd

Merge pull request #1 from supermodularxyz/localstorage-encoded-colle…

54435a6

…ctions Localstorage encoded collections

remove lock file

1c3d4f7

update indexer client

5e300e3

fix updates

2614cfd

remove collection owner

2f952eb

ghostffcode requested review from a team as code owners May 11, 2023 16:28

thelostone-mc requested review from nfrgosselin, michellema1208 and meglister May 12, 2023 09:47

thelostone-mc requested changes May 12, 2023

View reviewed changes

ghostffcode added 5 commits June 5, 2023 22:23

Localstorage encoded collections - Design & clean up updates (#2)

ce14c87

* star svg for lists * implement collections re-design * add isInCollection prop * clean up

remove unused packages

992dc37

remove duplicate roundId prop

43ea48c

add hack for new collections update

aab6c55

add empty state and lists link copy to clipboard

163af6e

vacekj marked this pull request as draft June 19, 2023 14:43

gravityblast mentioned this pull request Sep 13, 2023

review/merge collection feature #2336

Closed

vacekj mentioned this pull request Oct 18, 2023

Supermodularxyz main #2469

Closed

12 tasks

vacekj mentioned this pull request Oct 18, 2023

Collection PR #2470

Closed

14 tasks

thelostone-mc closed this Feb 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

URL encoded collection data for grant rounds #1786

URL encoded collection data for grant rounds #1786

ghostffcode commented May 11, 2023

thelostone-mc left a comment

thelostone-mc May 12, 2023

vacekj May 20, 2023

thelostone-mc May 12, 2023

thelostone-mc May 12, 2023

thelostone-mc May 12, 2023

thelostone-mc May 12, 2023

vacekj May 20, 2023

thelostone-mc May 12, 2023

thelostone-mc May 12, 2023

thelostone-mc May 12, 2023

thelostone-mc May 12, 2023

thelostone-mc May 12, 2023

vacekj May 20, 2023

owocki commented May 12, 2023

kevinrolsen commented May 12, 2023

melissa-neira commented May 12, 2023

owocki commented May 13, 2023

gravityblast commented May 18, 2023

meglister commented May 18, 2023

vacekj commented Jun 19, 2023 •

edited

ghostffcode commented Jun 20, 2023

vacekj commented Nov 23, 2023

thelostone-mc commented Feb 22, 2024


		const round: RoundResult = res.data.rounds[0];
		const round: RoundResult = res.data.rounds[0]

URL encoded collection data for grant rounds #1786

URL encoded collection data for grant rounds #1786

Conversation

ghostffcode commented May 11, 2023

Description

Refers/Fixes

Testing

thelostone-mc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented May 12, 2023

kevinrolsen commented May 12, 2023

melissa-neira commented May 12, 2023

owocki commented May 13, 2023

gravityblast commented May 18, 2023

meglister commented May 18, 2023

vacekj commented Jun 19, 2023 • edited

ghostffcode commented Jun 20, 2023

vacekj commented Nov 23, 2023

thelostone-mc commented Feb 22, 2024

vacekj commented Jun 19, 2023 •

edited