Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supermodularxyz main #2469

Closed
wants to merge 200 commits into from
Closed

Supermodularxyz main #2469

wants to merge 200 commits into from

Conversation

vacekj
Copy link
Member

@vacekj vacekj commented Oct 18, 2023

continuation of #1786

rebased on top of latest main

PR checklist

For every PR, make sure that these statements are true:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't contain type casts and non-null assertions.
  • Doesn't add @ts-ignore.
  • Doesn't disable lints.
  • Doesn't use useState just for computation - use plain variables instead.
  • Splits components into pure components that don't depend on external state or hooks.
  • Avoid embedding components within other components
  • Doesn't propagate optional values without good reason, doesn't mark property values as optional if that doesn't represent reality.
  • Doesn't duplicate existing code.
  • Parses out-of-domain data - this includes user input, API respones, on-chain data etc.
  • Doesn't contain commented out code.
  • Doesn't contain skipped or empty tests.

Subjective - at the discretion of the reviewers

  • Does things as simply as possible, but not simpler.
  • Doesn't reinvent the wheel or create premature abstractions.

ghostffcode and others added 30 commits May 10, 2023 18:06
* star svg for lists

* implement collections re-design

* add isInCollection prop

* clean up
…#1783)

* fix:explorer: handle replaced transactions on vote and token approval

* moved dependencies

* modified error handling

* disable next line null assertion
…nner (#1716)

* add/fixed verified badges, created, payout address, cropped banner

* increased timeout

* trigger actions

* fixed payout wallet and shield icons

* changed timeouts
…rivate (#1771)

* feat: add round type option in round details form

* feat: add roundType field validation

* test: update RoundDetailForm tests
also removes back buttons outside of design spec
this changes the navbar logo - once clicked it will take the user back to the origin + round path.
* feat: filter public rounds on explorer landingpage

* feat: add debug mode in explorer
vacekj and others added 27 commits October 18, 2023 15:44
Co-authored-by: Atris <vacekj@outlook.com>
Co-authored-by: Massimiliano Mirra <max@gitcoin.co>
* fix typechain script to include subfolders

* Direct round with feature flag

* run typechain before rm-build

* Revert "run typechain before rm-build"

This reverts commit 0d82502.

* fix typechain script

* fix import

* creat direct-round using factories

* fix some tests

* Fix tests: RoundApplicationForm

* fix CreateRoundContext.test.tsx

* fix: different titles for different types of rounds

* fix: titles' styles

* fix: no end date input's styles

* fix: radio button alignment

* fix: disabled end date's styles

* add: qf + dg buttons

* fix: wrong divs showing

* fix: buttons

* fix: footer

* add: create round modal

* fix: div width

* review changes

* fix tsc

* fix tests

* remove unnecessary gaslimit

* make use of TMP_DIRECT_ROUND_SUBGRAPH_URL as we need to keep the same SG queries

* fix test

* Hide create direct round when flag is off

* fix create round view when direct round flag is off

* fix round query

* add application detail question for DR

* DR: remove vault address on create
ALL: do not send Payout wallet question to metadata

* remove unused var

* direct-grant-round: rebasing commits to simplify rebase

fix typechain script to include subfolders

Direct round with feature flag

run typechain before rm-build

Revert "run typechain before rm-build"

This reverts commit 0d82502.

fix typechain script

fix import

wording

creat direct-round using factories

fix some tests

Fix tests: RoundApplicationForm

fix CreateRoundContext.test.tsx

fix: different titles for different types of rounds

fix: titles' styles

fix: no end date input's styles

fix: radio button alignment

fix: disabled end date's styles

add: qf + dg buttons

fix: wrong divs showing

fix: buttons

fix: footer

add: create round modal

fix: div width

direct grant round-details

misc round info

In review tab

remove unused vars

add: badges

add: more badges

fix: date styling

fix: alignment

add: badge

Fix #41 & #42

fix: date margin

add: round details elements

fix rebase

fix test

* direct-grant-round-in-review: squash commits to simplify rebase

fix test

in-review action

fix round applications tabs

wip: application in-review

InReview from application page

remove: debugger

fix tsc

fix tsc

fix default value for ApplicationsToApproveReject

Fix: remove @ from breadcrumb

fix: change No end time label to: No end time (open round)

fix: date format in two lines

Fix: No end date instead of No end time

fix test

* direct-grant-round-application-details: squashing commits to simplify rebase

fix test

in-review action

fix round applications tabs

wip: application in-review

InReview from application page

remove: debugger

fix tsc

fix tsc

fix default value for ApplicationsToApproveReject

add: application header

add: some application's page styles

fix: text size

add: sidebar items

tmp: comment tests

application sidebar info

fix lint

uncomment tests

fix: remove @ from breadcrumb, No end date instead of No end time

* direct-grant-round-application-payout: squashing to simplify rebase

* direct-grant-round-views: squashing to simplify rebase

round-manager: hides Round Results from left menu when DirectGrant rounds

round-manager: exports isQF validation for other components

round-manager: #37 hides Round Stats for DirectGrant rounds

round-manager: #40 hides Reclaim Funds for DirectGrant rounds

round-manager: #36 hides Funding Settings tab from Round Settings section or DirectGrant rounds

round-manager: #41 hides Application Dates from Program's Round list for DirectGrant rounds

round-manager: #36 hides application dates and references from Round Settings for DirectGrant rounds

round-manager: #48 hides Fund Contract section for DirectGrant rounds and fixes left menu items routing

round-manager: hides Fund Grantees section from Round Details view

round-manager: adds DirectRound schema validation

round-manager: inverts condition to determine direct rounds

* direct-grant-round-application-payout: squashing to simplify rebase

* view program page

ApplicationsToReview.test

application sidebar statuses

round-manager: round details views for direct grant rounds unit testing

git commit -m viewApplicationPage sidebar statuses

rendered payout component for DR approved

ApplicationDirectPayout

* direct payout view

* non working test

* fix payout test

* uncomment tests

* checking UT

* fix non null assertion

* fix viewApplicationPage.test

* ApplicationDirectPayout

* replace builder & explorer

* fix: lint issues

* feat: add direct grant contracts for mainnet & op

* feat: add dgVotingStrategyDummyContract for OP

* feat: move builder url to env

* feat: make milestones optional

* fix: no round end date bug

* fix: unable to view approved applications

* fix: failing tests

* feat: Remove matching funds & passport for DG

* feat: remove donation option in DG

* fix: other bugs

* Fix end date display for direct grants (#19)

* fix: no round end date bug

* fix: no end time bug in explorer

* fix: default value for roundEndDate in editMode

* fix: build issues in round manager

* fix: build issues

* fix: deployRoundContract issue

* fix: builder issues

* fix: explorer build issues

* fix: explorer conflicts in utils

* fix: conflicts in common

* fix: conflicts in RoundCard

* fix: round detail form

* fix: lint issues

* fix explorer tests

* fix: manager tests

* fix: explorer type check issues

* fix: explorer tests

* fix: manager tests

* fix: deploy round issue

* chore: implement engineering review feedback

* fix: lint issues

* fix: rm build issues

---------

Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>
Co-authored-by: Gabito Esmiapodo <gabriel@bootnode.dev>
Co-authored-by: nicolas <nicosampler@users.noreply.github.com>
Co-authored-by: tomasloffler <tomasloffler@gmail.com>
Co-authored-by: Marcelo Rubini <rubini.marcelo@gmail.com>
* feat: update dg factory contracts

* feat: update dg voting contracts

* fix: getRoundById
* make sure pinata requests don't fail if base URL ends with a '/'

* use the instance var for gateway

* remove trailing slash from pinata GATEWAY using replace
* fix: download csv bug

* chore: rename ApplicationsToApproveReject
Co-authored-by: Atris <vacekj@outlook.com>
* add the PowerPool token (CVP) in the payout tokens

* make direct grant question "payout token" editable

* add power pool logo

* feat: enable single option in a dropdown

* fix: don't show matching funds in dg pre round

* feat: enable custom payout in dg

* fix: remove gas limit

---------

Co-authored-by: eagle <aparokshambhargav@gmail.com>
Co-authored-by: Atris <vacekj@outlook.com>
* fix: incorrect token name bug in donations page

* fix: other token name issues

* fix: token name issues
Co-authored-by: Atris <vacekj@outlook.com>
Co-authored-by: Andrea Franz <andrea@gravityblast.com>
Co-authored-by: Massimiliano Mirra <max@gitcoin.co>
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview Oct 18, 2023 2:01pm
builder-staging ✅ Ready (Inspect) Visit Preview Oct 18, 2023 2:01pm
explorer ❌ Failed (Inspect) Oct 18, 2023 2:01pm
explorer-staging ❌ Failed (Inspect) Oct 18, 2023 2:01pm
manager ✅ Ready (Inspect) Visit Preview Oct 18, 2023 2:01pm
manager-staging ✅ Ready (Inspect) Visit Preview Oct 18, 2023 2:01pm

@vacekj vacekj closed this Oct 18, 2023
@vacekj vacekj deleted the supermodularxyz-main branch October 18, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet