Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funded issue links are long and clunky #201

Closed
owocki opened this issue Jan 2, 2018 · 6 comments
Closed

funded issue links are long and clunky #201

owocki opened this issue Jan 2, 2018 · 6 comments

Comments

@owocki
Copy link
Contributor

owocki commented Jan 2, 2018

https://gitcoin.co/funding/details?url=https://github.com/trufflesuite/truffle/issues/343

this could easily be collapsed to

https://gitcoin.co/funding/details/trufflesuite/truffle/issues/343

requirements

  • make it so that the above link format works
  • maintain backwards comipatibility
  • update all external facing links for bounties to go to the new link format
@eswarasai
Copy link
Contributor

@owocki -- Possible solution for this issue:

  1. New URL route for Bounty -- Create a new method which will be similar to the existing bounty_details in dashboard. Just a slight modification to the way we fetch the GitHub URL from the request. We just need to replace by https://github.com in the request path
  2. Maintain backwards compatibility -- The existing bounty_details request will simply redirect to the new URL in the expected format
  3. Update all external facing links for bounties to go to the new link format -- Fixing 2) should automatically handle this

@owocki
Copy link
Contributor Author

owocki commented Jan 2, 2018

good thoughts :)

@step21
Copy link

step21 commented Jan 26, 2018

I took a look/almost finished it... I think. But when replacing this in the js files and extracting orga/user, repo and issue number - right now I just followed/copied the existing patterns so there is one api url/github request for each. Or is this info already saved somewhere that I missed?

@step21
Copy link

step21 commented Jan 26, 2018

New branch here https://github.com/step21/web/tree/url-change

@owocki
Copy link
Contributor Author

owocki commented Jan 26, 2018

Or is this info already saved somewhere that I missed?

not that im aware of.. but you could parse it in the python view and then pass it down in the template (as opposed to having to re-parse it in the JS file)

@owocki
Copy link
Contributor Author

owocki commented Feb 14, 2018

@lazaridiscom i like that URL structure :)

@step21 are you still actively working on this? happy to have someone else take a look at it if you've gotten pulled in another direction

@owocki owocki closed this as completed Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants