New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build - You've Received Kudos Email #2841
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 0.45 ETH (82.07 USD @ $182.39/ETH) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 3 weeks, 4 days ago. 1) kuhnchris has been approved to start work. As requested, i'll implement the fancy changes! #sparkle Learn more on the Gitcoin Issue Details page. |
|
@kuhnchris could we add some breathing space between the button and the text below it ? else lgtm ^_^ |
We could, but useless, since EITHER Accept Kudos OR automatic remit is displayed. ;-) |
Could you raise a PR ? |
Sure. I managed, thanks to @mbeacom, to load kudos into my test environment and create test mails. I'll create a intermediate PR (WIP) so you guys can check it, OK? :-) |
Looking nice @kuhnchris , just an important thing is to test is in real email, because the pain of emails is the clients change some code and things render a little different. |
thats why i implemented maildev, we can allow it to relay mails matching a certain domain (for example *@gitcoin.co) and see all other outgoing mails in the web interface. if you do not mind ill whitelist your mail and send you a rinkeby kudos so you can take a look (i would have attached the eml but its not allowed on github) |
@kuhnchris great, tell me if you need something on my side. my email is octavioamuchastegui@gmail.com |
@kuhnchris Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
1 similar comment
@kuhnchris Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Sent you a mail @octavioamu . |
i'm so excited for this! |
@kuhnchris how is going? |
Hi there @octavioamu status is in the PR, mbeacon wants me to do some changes and then I think we are OK with this, except you want some more changes |
This comment has been minimized.
This comment has been minimized.
I... did? |
This comment has been minimized.
This comment has been minimized.
1 similar comment
@kuhnchris Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
This comment has been minimized.
This comment has been minimized.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 0.45 ETH (40.09 USD @ $89.08/ETH) has been submitted by: @PixelantDesign please take a look at the submitted work:
|
[WOC] #2841 New Kudos Email template
Reserved for @kuhnchris
User Story
As a Kudos user I'd like to have a feeling of surprise and delight when I open an email explaining I've received Kudos.
Why Is this Needed
The current implementation is not as exciting and doesn't enhance the Kudos artwork as it could.
Description
This is is to update the existing visual design. There are no functional changes to this email.
Definition of Done
Additional Information
Reference this design ticket #2712
RecdKudosEmail1114.zip
The text was updated successfully, but these errors were encountered: