Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build - You've Received Kudos Email #2841

Closed
4 tasks
PixelantDesign opened this issue Nov 15, 2018 · 23 comments
Closed
4 tasks

Build - You've Received Kudos Email #2841

PixelantDesign opened this issue Nov 15, 2018 · 23 comments
Labels
Gitcoin Kudos Gitcoin Kudos

Comments

@PixelantDesign
Copy link
Contributor

Reserved for @kuhnchris

User Story

As a Kudos user I'd like to have a feeling of surprise and delight when I open an email explaining I've received Kudos.

Why Is this Needed

The current implementation is not as exciting and doesn't enhance the Kudos artwork as it could.

Description

This is is to update the existing visual design. There are no functional changes to this email.

Definition of Done

  • Implement new background
  • Ensure the entire emeial works in a responsive manner
  • For email clients that end up not loading the background, build a fallback to ensure text is legible, use text color html: replaced slack image with font-awesome icon #333
  • Review with core team members

Additional Information

Reference this design ticket #2712

received kudos_final

RecdKudosEmail1114.zip

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.45 ETH (82.07 USD @ $182.39/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Nov 15, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 weeks, 4 days ago.
Please review their action plans below:

1) kuhnchris has been approved to start work.

As requested, i'll implement the fancy changes! #sparkle

Learn more on the Gitcoin Issue Details page.

@kuhnchris
Copy link
Contributor

image
First draft - that's OK that way @PixelantDesign ?
I'll implement that in the meantime into the template

@thelostone-mc
Copy link
Member

@kuhnchris could we add some breathing space between the button and the text below it ? else lgtm ^_^

@kuhnchris
Copy link
Contributor

We could, but useless, since EITHER Accept Kudos OR automatic remit is displayed. ;-)

@kuhnchris
Copy link
Contributor

Hey there, templates implemented!
image
but... as noted above, the lines left and right are "globally for all mails", if we want to change it we'd have 1 mail stand out against the other templates. I kept it to go with the flow, sadly I'm a bit too uneducated to generate rinkeby test kudos, so the test-data is bonkers. :-(

Let me know if you have any more first pain points to fix

@thelostone-mc
Copy link
Member

Could you raise a PR ?
@octavioamu / me can help test it out

@kuhnchris
Copy link
Contributor

Sure. I managed, thanks to @mbeacom, to load kudos into my test environment and create test mails. I'll create a intermediate PR (WIP) so you guys can check it, OK? :-)

@octavioamu
Copy link
Contributor

Looking nice @kuhnchris , just an important thing is to test is in real email, because the pain of emails is the clients change some code and things render a little different.

@kuhnchris
Copy link
Contributor

thats why i implemented maildev, we can allow it to relay mails matching a certain domain (for example *@gitcoin.co) and see all other outgoing mails in the web interface. if you do not mind ill whitelist your mail and send you a rinkeby kudos so you can take a look (i would have attached the eml but its not allowed on github)

@octavioamu
Copy link
Contributor

@kuhnchris great, tell me if you need something on my side. my email is octavioamuchastegui@gmail.com

@gitcoinbot
Copy link
Member

@kuhnchris Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link
Member

@kuhnchris Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@kuhnchris
Copy link
Contributor

Sent you a mail @octavioamu .

@owocki
Copy link
Contributor

owocki commented Nov 28, 2018

i'm so excited for this!

@octavioamu
Copy link
Contributor

@kuhnchris how is going?

@kuhnchris
Copy link
Contributor

Hi there @octavioamu status is in the PR, mbeacon wants me to do some changes and then I think we are OK with this, except you want some more changes

@gitcoinbot

This comment has been minimized.

@kuhnchris
Copy link
Contributor

I... did?

@gitcoinbot

This comment has been minimized.

1 similar comment
@gitcoinbot
Copy link
Member

@kuhnchris Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot

This comment has been minimized.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.45 ETH (40.09 USD @ $89.08/ETH) has been submitted by:

  1. @kuhnchris

@PixelantDesign please take a look at the submitted work:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Kudos Gitcoin Kudos
Projects
None yet
Development

No branches or pull requests

6 participants