Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitcoin Profile Detail Page Does Not Include Coins Other than ETH #4590

Closed
mkosowsk opened this issue Jun 7, 2019 · 11 comments
Closed

Gitcoin Profile Detail Page Does Not Include Coins Other than ETH #4590

mkosowsk opened this issue Jun 7, 2019 · 11 comments
Labels

Comments

@mkosowsk
Copy link

mkosowsk commented Jun 7, 2019

Screen Shot 2019-06-07 at 6 45 42 AM

I'm the #17 funder on Gitcoin but it shows my contributions as 0.00 ETH! That's because I use DAI to fund and this PR will fix that and protect my fragile ego!

User Story

As a Gitcoin funder
I want to have my coins in addition to ETH represented in my funding amounts
So that I can flex my bags on these n00bs

Description

Type: Feature

Current Behavior

Only shows ETH on profile page

Expected Behavior

Different options here, I'll order them in what I think is order of increasing difficulty

  1. Just show DAI in addition to ETH (my MVP for this)
  2. Show top 3 coins in addition to ETH (probably what I will strive for)
  3. Show all coins funder has used (probably won't attempt here but could be future work)

Definition of Done

  1. Coins other than ETH are shown on Funder profile page
  2. My fragile ego is protected once more
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.5 ETH (124.12 USD @ $248.24/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Jun 7, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 days, 19 hours from now.
Please review their action plans below:

1) rafalkowalski has been approved to start work.

First of all i will verify how eth coin is visible and then i will add implementation for other coins
2) mkosowsk has applied to start work (Funders only: approve worker | reject worker).

ETA middle of next week

Hop back into the codebase with help from Gitcoin core and pump out a nice solution, probably #1 on my list
3) kilimanjaro2 has applied to start work (Funders only: approve worker | reject worker).

This looks like a great first bug to fix. I would love to attempt. It should not take more than a day.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link
Member

💰 A crowdfund contribution worth 150.00000 DAI (150.0 USD @ $1.0/DAI) has been attached to this funded issue from @ghettodev.💰

Want to chip in also? Add your own contribution here.

@PixelantDesign
Copy link
Contributor

Hey yall! Thanks for your interest in helping to solve this one! I had already talked to Rafal about this task prior to bounty. I do have another bounty here if yall are interested! https://gitcoin.co/issue/gitcoinco/web/4398/3097

Also feel free to hit me up if any of the good first issue/easy pickings from our github web backlog seem interesting to you!

@gitcoinbot
Copy link
Member

@rafalkowalski Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link
Member

@rafalkowalski Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@rafalkowalski
Copy link
Contributor

@gitcoinbot I'm working on it. I'm waiting for a review

@thelostone-mc
Copy link
Member

@rafalkowalski it's merged!
@mkosowsk * drumroll *

we are good for payout ^_^

@gitcoinco gitcoinco deleted a comment from gitcoinbot Jun 23, 2019
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.5 ETH (155.11 USD @ $310.22/ETH) has been submitted by:

  1. @rafalkowalski

@PixelantDesign please take a look at the submitted work:


@gitcoinbot
Copy link
Member

Pythonista ⚡️ A *Pythonista* Kudos has been sent to @rafalkowalski for this issue from @PixelantDesign. ⚡️

Nice work @rafalkowalski!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.5 ETH (145.71 USD @ $291.43/ETH) (plus a crowdfund of 150.0 DAI worth 150.0 USD) attached to this issue has been approved & issued to @rafalkowalski.

Thanks to @ghettodev for their crowdfunded contributions to this bounty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants