Identify Trust Wallet (instead of Metamask)

[owocki]

https://github.com/TrustWallet/trust-web3-provider

If the user is using a non metamask wallet, we should be able to handle that in both name / imagery:

[jvluso]

I'd like to also be able to use the frame provider. https://github.com/floating/frame . Some of the hardcoded references to metamask appear to have been added back in when privacy mode was introduced.

[spm32]

@owocki just wanted to bump this to see if it's something we can tackle in advance of Aracon :)

[spm32]

Hey @owocki wanted to bump this once more just since it came up in conversation today.

[owocki]

its in the green team sprint backlog

[octavioamu]

so yes there is not many docs about how to integrate, the link in the description is for android / ios support of web3.js so looking at that and some github repos of dapps working on trust wallet I suppose the way to go is adding web3.js and stop using the metamask light web3.js version. I think this is bigger than just trust wallet, today we have opera!! with crypto and collectibles support I configurated my metamask wallet there also and works like a charm.
Anyway doing this switch will be important for support gitcoin in other many wallets apps / browsers.
CC: @PixelantDesign

[spm32]

Hey @octavioamu we don't have to prioritize this ticket for the coming sprint as we won't be able to announce the integration at Aracon, we should aim to do this by end of March though but if you have other items you think are more important I think we can put them ahead.

I do still agree that being able to support other wallets / browsers is important especially with Opera integrating their own wallet recently. I can probably get Charles to promote that as 'Gitcoin supports Opera' once that's done.

[octavioamu]

@ceresstation Just to know, why won't be able to announce the integration at Aracon?
Anyway I believe as you is very important to handle All wallets or as many as we can. Not sure if you was able to check in the channel but this is the current progress so far
https://share.vidyard.com/watch/PjEbzuatUY7R941EpCULq8

[kuhnchris]

@octavioamu did this ever make it to prod?

[octavioamu]

not sure this original ticket has a merged PR my video is about using opera wallet and is a WIP #3983

[kuhnchris]

guess i'll have to throw the question back to you then @owocki . :-( (sorry)

[octavioamu]

but what do you want to know?

[kuhnchris]

I just wanted to know if:
a.) this issue is still being relevant
b.) there are still hardcoded references to metamask and
c.) if this was superseeded by your aforementioned PR.

Thanks!

[octavioamu]

answering from my side
a) I believe making gitcoin open to other wallets more than metamask is very relevant.
b) yes the metamask code is not modularised that why I just added support to opera just to tips in my pr.
c) My approach is kind of more general to use add web3js and use it, with that adding support to opera, wallets browsers etc. Not sure about "trust wallet" specific.

One of the things I tested is metamask mobile, and is not working on gitcoin, this time because the browser version they use is old and github doesn't support it, so you can't login into github there. (I already submitted a feedback for them about this)