Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify trust wallet #882

Merged
merged 1 commit into from Apr 13, 2018
Merged

identify trust wallet #882

merged 1 commit into from Apr 13, 2018

Conversation

kziemianek
Copy link
Contributor

Description

Identify and handle trust wallet both in name and imaginery.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows [commit guidelines]
Affected core subsystem(s)

frontend

Testing

locally

Refers/Fixes

Refs: #680

@kziemianek
Copy link
Contributor Author

image

@mbeacom mbeacom added needs-testing frontend This needs frontend expertise. labels Apr 13, 2018
@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

Merging #882 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #882   +/-   ##
=======================================
  Coverage   33.85%   33.85%           
=======================================
  Files          99       99           
  Lines        5925     5925           
  Branches      705      705           
=======================================
  Hits         2006     2006           
  Misses       3828     3828           
  Partials       91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8cda7...f1e256e. Read the comment docs.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm - Thanks @kziemianek !

@owocki
Copy link
Contributor

owocki commented Apr 13, 2018

theres a few other hardcoded references to metamask across the site... but this is a good start!

@owocki owocki merged commit 7937465 into gitcoinco:master Apr 13, 2018
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.05 ETH (25.7 USD @ $513.94/ETH) has been granted to @kziemianek for this issue from Kevin. ⚡️

The sender had the following public comments:

Its been great having you around to steward the repos :)

Nice work @kziemianek! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@spm32 spm32 added this to Sprint Backlog in Green Team Board Jan 15, 2019
@spm32 spm32 removed this from Sprint Backlog in Green Team Board Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants