Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR: Adds disclosure and consent withdrawal information in privacy tab #1248

Merged
merged 2 commits into from May 24, 2018

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented May 23, 2018

Description

Adds the following information in the privacy settings

  • disclose The purposes for collecting the information and how it will be used (e.g., provide updates, marketing)
  • add 'Notice that the user may withdraw consent at any time and instructions on how to do so (e.g., by clicking an unsubscribe link in the email or contacting the spoke directly)'
  • our privacy contact info
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing

Following is the screenshot:
screenshot-2018-5-24 privacy settings 1

Refers/Fixes

Fixes #1235

@ghost ghost assigned SaptakS May 23, 2018
@ghost ghost added the in progress label May 23, 2018
@SaptakS SaptakS requested review from owocki and mbeacom May 23, 2018 23:17
@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #1248 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1248      +/-   ##
==========================================
- Coverage   31.53%   31.49%   -0.04%     
==========================================
  Files         118      118              
  Lines        8192     8192              
  Branches     1069     1069              
==========================================
- Hits         2583     2580       -3     
- Misses       5499     5502       +3     
  Partials      110      110
Impacted Files Coverage Δ
app/app/settings.py 83.61% <0%> (-1.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3deda9b...0627d3e. Read the comment docs.

mbeacom
mbeacom previously approved these changes May 23, 2018
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SaptakS
Copy link
Contributor Author

SaptakS commented May 23, 2018

Merge this only after #1246 is merged. Else due to failure in finding reverse_url for account_settings the privacy page will fail to load. It depends on this change

thelostone-mc
thelostone-mc previously approved these changes May 24, 2018
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SaptakS SaptakS dismissed stale reviews from thelostone-mc and mbeacom via 300c186 May 24, 2018 10:29
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost ghost assigned mbeacom May 24, 2018
@thelostone-mc thelostone-mc merged commit b33d495 into gitcoinco:master May 24, 2018
@ghost ghost removed the in progress label May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDPR: Settings Content Updates
3 participants