Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Travis failures on dependency conflict #143

Merged
merged 1 commit into from Dec 18, 2017
Merged

Resolve Travis failures on dependency conflict #143

merged 1 commit into from Dec 18, 2017

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Dec 18, 2017

Description

The goal of this PR is to resolve #142 by pinning cytoolz to 0.8.2 and resolving an isort error in cleanup_db_space.py file.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

Travis CI

Refers/Fixes

Fixes #142

@codecov
Copy link

codecov bot commented Dec 18, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@e7280bf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage          ?   12.28%           
=========================================
  Files             ?       66           
  Lines             ?     3094           
  Branches          ?      343           
=========================================
  Hits              ?      380           
  Misses            ?     2714           
  Partials          ?        0
Impacted Files Coverage Δ
.../dashboard/management/commands/cleanup_db_space.py 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7280bf...2e41776. Read the comment docs.

@mbeacom mbeacom changed the title Fix #142 - Attempt to resolve Travis req dependency conflict and isort Resolve Travis failures on dependency conflict Dec 18, 2017
@owocki owocki merged commit 9ef432d into gitcoinco:master Dec 18, 2017
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.05 ETH ($38.33) has been granted to @mbeacom for this issue from Kevin. ⚡️

The sender had the following public comments:

The boy scouts have a rule: Always leave the campground cleaner than you found it. Thanks for being a boy scout!

Nice work @mbeacom, check your email for further instructions.

@mbeacom mbeacom deleted the fix-travis-builds branch December 18, 2017 22:55
ethikz pushed a commit to ethikz/web that referenced this pull request Jan 24, 2018
Resolve Travis failures on dependency conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis builds failing on cytoolz
3 participants