Discord test button and send webhook msg with avatar #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Profile.get_discord_repos for presentation of discord_repos * Fix splitting of repo string before saving into discord/slack repos * Remove "Test" button in Discord settings as it is out of scope * Remove mutation for Bounty.bounty_owner_profile in migration * Add discord_repos and discord_webhook_url fields for profile fixtures
|
For some reason, my User no longer has its Profile created after logging in via the Github integration on my dev environment, so am stuck on that before I can test the new functionality. Will update again later this week when I have more time to troubleshoot. Unsure if the issue is with my changes, none of them touch the Github integration. |
kelvintyb
changed the title
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
+ Coverage 29.69% 29.73% +0.04%
==========================================
Files 132 130 -2
Lines 9784 9733 -51
Branches 1270 1260 -10
==========================================
- Hits 2905 2894 -11
+ Misses 6773 6735 -38
+ Partials 106 104 -2
Continue to review full report at Codecov.
|
mbeacom
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As detailed in #1434, this PR adds test functionality to the Discord integration as well as setting of the webhook avatar when posting a message through the webhook.
Checklist
Affected core subsystem(s)
Backend (marketing/utils, marketing/views, dashboard/notifications)
Frontend (settings/discord)
Testing
Tested:
Refers/Fixes
Fixes: #1434