Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how it works to use one url #1536

Merged
merged 1 commit into from Jun 25, 2018
Merged

Update how it works to use one url #1536

merged 1 commit into from Jun 25, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Jun 25, 2018

Description

The goal of this PR is to consolidate the how it works urls to use one entry and pass the type to the view.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Testing

Tested locally

@mbeacom mbeacom added the backend This needs backend expertise. label Jun 25, 2018
@mbeacom mbeacom self-assigned this Jun 25, 2018
@ghost ghost added the in progress label Jun 25, 2018
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #1536 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
- Coverage   28.27%   28.27%   -0.01%     
==========================================
  Files         129      129              
  Lines        9523     9525       +2     
  Branches     1231     1232       +1     
==========================================
  Hits         2693     2693              
- Misses       6732     6734       +2     
  Partials       98       98
Impacted Files Coverage Δ
app/app/urls.py 89.74% <ø> (ø) ⬆️
app/retail/views.py 38.46% <50%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8036b1...3ca6bd1. Read the comment docs.

@SaptakS SaptakS merged commit fe004ce into master Jun 25, 2018
@ghost ghost removed the in progress label Jun 25, 2018
@mbeacom mbeacom deleted the update-how-it-works-url branch June 25, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants