Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatar schwag request form #1551

Merged
merged 2 commits into from Jun 29, 2018
Merged

avatar schwag request form #1551

merged 2 commits into from Jun 29, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jun 26, 2018

adds the following link on the avatar builder page:

screen shot 2018-06-26 at 8 01 39 am

which allows users to request more avatar items on a github thread

@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #1551 into master will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1551      +/-   ##
==========================================
+ Coverage   28.29%   29.04%   +0.75%     
==========================================
  Files         130      130              
  Lines        9536    10045     +509     
  Branches     1235     1360     +125     
==========================================
+ Hits         2698     2918     +220     
- Misses       6740     7008     +268     
- Partials       98      119      +21
Impacted Files Coverage Δ
app/avatar/admin.py 80.64% <0%> (-19.36%) ⬇️
app/github/utils.py 59.75% <0%> (-0.25%) ⬇️
app/dashboard/embed.py 7.81% <0%> (+0.45%) ⬆️
app/avatar/models.py 42.71% <0%> (+0.82%) ⬆️
app/dashboard/models.py 57.8% <0%> (+1.63%) ⬆️
app/dashboard/views.py 16.64% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c81f1a...1afd31e. Read the comment docs.

mbeacom
mbeacom previously approved these changes Jun 26, 2018
Copy link
Contributor

@PixelantDesign PixelantDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when I click the link?

@SaptakS
Copy link
Contributor

SaptakS commented Jun 28, 2018

@PixelantDesign it takes you to this issue

@thelostone-mc
Copy link
Member

@PixelantDesign So it redirects you to a github issue #1550 where they can leave a comment

@mbeacom
Copy link
Contributor

mbeacom commented Jun 28, 2018

Updated to use rel="noopener noreferrer"

@SaptakS
Copy link
Contributor

SaptakS commented Jun 28, 2018

@mbeacom thanks. I was actually doing the same. 😅

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 ?

@thelostone-mc thelostone-mc merged commit f876dcb into master Jun 29, 2018
@ghost ghost removed the in progress label Jun 29, 2018
@thelostone-mc thelostone-mc deleted the kevin/requests branch June 29, 2018 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants