Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overflow in header if minihero not present #2080

Merged
merged 2 commits into from Aug 27, 2018

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented Aug 23, 2018

Description

The navbar dropdown problem was persistent in error page. Hopefully fixed that

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing

Couldn't test error page locally. @mbeacom can you help?

Refers/Fixes

@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #2080 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2080   +/-   ##
=======================================
  Coverage   27.94%   27.94%           
=======================================
  Files         133      133           
  Lines       10941    10941           
  Branches     1471     1471           
=======================================
  Hits         3057     3057           
  Misses       7775     7775           
  Partials      109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08c516...a086491. Read the comment docs.

@thelostone-mc thelostone-mc self-requested a review August 24, 2018 20:11
@thelostone-mc thelostone-mc added the bug This is something that isn't working as intended. label Aug 24, 2018
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@thelostone-mc thelostone-mc merged commit c66cbc9 into gitcoinco:master Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants