Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrates from current_bounty=True to .current() because the latter is… #2161

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
2 participants
@owocki
Copy link
Member

commented Sep 5, 2018

… more exhaustive

follow up to #2105

@mbeacom mbeacom added the in progress label Sep 5, 2018

@codecov

This comment has been minimized.

Copy link

commented Sep 5, 2018

Codecov Report

Merging #2161 into master will not change coverage.
The diff coverage is 8.33%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2161   +/-   ##
======================================
  Coverage    27.8%   27.8%           
======================================
  Files         137     137           
  Lines       11178   11178           
  Branches     1510    1510           
======================================
  Hits         3108    3108           
  Misses       7960    7960           
  Partials      110     110
Impacted Files Coverage Δ
app/marketing/stats.py 0% <ø> (ø) ⬆️
...ernal_bounties/management/commands/sync_gitcoin.py 0% <0%> (ø) ⬆️
app/dashboard/management/commands/sync_profiles.py 0% <0%> (ø) ⬆️
app/economy/management/commands/get_prices.py 0% <0%> (ø) ⬆️
...ard/management/commands/create_activity_records.py 0% <0%> (ø) ⬆️
...pp/economy/management/commands/refresh_bounties.py 0% <0%> (ø) ⬆️
app/retail/emails.py 20.18% <0%> (ø) ⬆️
app/marketing/utils.py 29.72% <0%> (ø) ⬆️
...p/dashboard/management/commands/activity_report.py 0% <0%> (ø) ⬆️
app/dataviz/d3_views.py 9.55% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a885e...dfaf3f5. Read the comment docs.

@mbeacom

mbeacom approved these changes Sep 5, 2018

@mbeacom mbeacom merged commit b53e584 into master Sep 5, 2018

6 of 7 checks passed

codecov/patch 8.33% of diff hit (target 27.8%)
Details
ci/circleci Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/project 27.8% remains the same compared to c8a885e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found.

@mbeacom mbeacom deleted the kevin/current_bounty_refactor_2 branch Sep 5, 2018

@mbeacom mbeacom removed the in progress label Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.