Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace project length with time commitment #2190

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Replace project length with time commitment #2190

merged 1 commit into from
Sep 11, 2018

Conversation

arku
Copy link
Contributor

@arku arku commented Sep 11, 2018 •
edited
Loading

Replace text 'Project Length' with 'Time Commitment'

Screenshots
New bounty form

image

Bounty details

image

Sidebar search filter

image

/cc @PixelantDesign

@codecov
Copy link

codecov bot commented Sep 11, 2018 •
edited
Loading

Codecov Report

Merging #2190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2190   +/-   ##
=======================================
  Coverage   27.75%   27.75%           
=======================================
  Files         141      141           
  Lines       11367    11367           
  Branches     1543     1543           
=======================================
  Hits         3155     3155           
  Misses       8102     8102           
  Partials      110      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331e5f3...afaeb91. Read the comment docs.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.17 ETH attached to it.

@thelostone-mc
Copy link
Member

@arun1595 could we get a screenshot of how it looks ?

@arku
Copy link
Contributor Author

arku commented Sep 11, 2018

@thelostone-mc Will update the PR tomorrow with a screenshot.

@arku
Copy link
Contributor Author

arku commented Sep 11, 2018

@anshumanv Yeah, I'm.

@anshumanv
Copy link
Contributor

Cool cool, I thought this is an issue. 😅

@thelostone-mc
Copy link
Member

thelostone-mc commented Sep 11, 2018 •
edited
Loading

@Manjilan ah my man @arun1595 already got to this. 😅
Dude click on start work -.-

@PixelantDesign this is how it looks

screen shot 2018-09-11 at 11 18 41 pm

thelostone-mc
thelostone-mc approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@thelostone-mc thelostone-mc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh LGTM! Didn't wanna wait till you threw in a screenshot 😅

@thelostone-mc thelostone-mc merged commit d30c1c9 into gitcoinco:master Sep 11, 2018
mbeacom
mbeacom reviewed Sep 11, 2018
View reviewed changes
app/dashboard/templates/bounty/details.html
@@ -93,7 +93,7 @@ <h4 id="title" class="font-title"></h4>
</div>

<div>
<span class="bounty-info-heading">{% trans "Project Length" %}</span>
<span class="bounty-info-heading">{% trans "Time Commitment" %}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to run make autotranslate or makemessages/compilemessages via manage.py following changes like this. @arun1595 @thelostone-mc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad ! totally slipped my mind

@arku arku deleted the time-commitment branch September 11, 2018 19:38
@PixelantDesign
Copy link
Contributor

Good to pay out @mbeacom ?

@gitcoinbot
Copy link
Member

gitcoinbot commented Sep 11, 2018 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 week, 5 days ago.
Please review their action plans below:

1) arun1595 has been approved to start work.

I'll replace 'Project Length' with 'Time commitment' in bounty details, new bounty form and sidebar search.

Learn more on the Gitcoin Issue Details page.

@mbeacom
Copy link
Contributor

mbeacom commented Sep 12, 2018

😂 Yep. @PixelantDesign

@thelostone-mc
Copy link
Member

I'll replace 'Project Length' with 'Time commitment' in bounty details, new bounty form and sidebar search.

@arun1595 well played :P

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.17 ETH has been submitted by:

  1. @arun1595

@PixelantDesign please take a look at the submitted work:

@arku
Copy link
Contributor Author

arku commented Sep 12, 2018

@thelostone-mc haha, I had to time travel 😉

credits to @PixelantDesign for creating a bounty from a PR 😀

@frankchen07 frankchen07 mentioned this pull request Sep 28, 2018
Closed
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.17 ETH attached to this issue has been approved & issued to @arun1595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@mbeacom mbeacom mbeacom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@arku @gitcoinbot @thelostone-mc @anshumanv @PixelantDesign @mbeacom