Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin django-redis==4.10.0 #2891

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Pin django-redis==4.10.0 #2891

merged 1 commit into from
Nov 19, 2018

Conversation

pinkiebell
Copy link
Contributor

I get random errors on my local docker setup if I use
the site and constant errors for things like POST and
api calls.

For example:

web_1    | redis.exceptions.DataError: Invalid input of type: 'CacheKey'. Convert to a byte, string or number first.

Details of this issue are here:
jazzband/django-redis#342

The latest djang-redis release fixes the issues.

I get random errors on my local docker setup if I use
the site and constant errors for things like POST and
api calls.

For example:
```
web_1    | redis.exceptions.DataError: Invalid input of type: 'CacheKey'. Convert to a byte, string or number first.
```

Details of this issue are here:
jazzband/django-redis#342

The latest djang-redis release fixes the issues.
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #2891 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2891   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files         171      171           
  Lines       13418    13418           
  Branches     1785     1785           
=======================================
  Hits         4027     4027           
  Misses       9258     9258           
  Partials      133      133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69a7cc...eb3e883. Read the comment docs.

@mbeacom
Copy link
Contributor

mbeacom commented Nov 19, 2018

lgtm - thanks! 🚢

@mbeacom mbeacom merged commit e430877 into gitcoinco:master Nov 19, 2018
@pinkiebell pinkiebell deleted the fix/redis branch January 3, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants