Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix condition in featured new bounty email #3928

Merged
merged 4 commits into from Mar 13, 2019
Merged

Conversation

octavioamu
Copy link
Contributor

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #3928 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3928   +/-   ##
======================================
  Coverage      30%     30%           
======================================
  Files         205     205           
  Lines       15949   15949           
  Branches     2108    2108           
======================================
  Hits         4785    4785           
  Misses      10992   10992           
  Partials      172     172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19a3e0...8de08b6. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easiest review ever! ;) Thanks Octavio for the fix!

@danlipert danlipert merged commit ea3c279 into master Mar 13, 2019
@thelostone-mc thelostone-mc deleted the fix/email-w-featured branch March 27, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants