New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup syntax and linting issues for backend code #577
Conversation
Remove unused imports, fix indentations, redundent imports, remove unused files, etc.
seems okay to me if it's just linting.. this is gonna cause a lot of merge conflicts. two questions:
|
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 29.05% 29.11% +0.05%
==========================================
Files 93 88 -5
Lines 4890 4880 -10
Branches 571 571
==========================================
Hits 1421 1421
+ Misses 3422 3412 -10
Partials 47 47
Continue to review full report at Codecov.
|
@owocki Agreed, regarding merge conflicts... but we need to get the BE code to a place we can automatically check linting at some point without introducing a stoppage point for every change initiated against the files that were modified here. This is the first step in one of multiple to get the BE to a point we can lint and not hinder users from contributing without resolving previously existing linting errors. There are no needed changes to Travis yet, but I can add documentation to the contributing doc regarding linters to run, i.e.: As for testing, I tested this locally and all seemed fine. Most of the changes aren't modifications to logic, but rather some syntax changes and removal of unused imports and skeleton files. The only thing that should be outstanding following this PR for CI enforced linting should be the functions that violate mccabe checks for complexity, number of local vars, and number of method arguments (from an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
+1 |
Description
The goal of this PR is to cleanup some of the backend code to adhere to flake8/pylint standards.
Additionally, this PR removes many unused files and imports.
Checklist