destroys legacy bounty handling code (except for on legacy kill bounty page) #589

owocki · 2018-03-10T14:59:34Z

Description

As an artifact of our integration with standard bounties, we have a straggling bunch of bounties on the old Gitcoin smart contracts.

This PR destroys the legacy bounty handling code.

Still TODO

What legacy bounties remain?
What can we do to close down those bounties and/or migrate them over to standardbounties? How can we make it easy for the parties involved in those bounties to do so?

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

bounties (legacy)

Refers/Fixes

#406

owocki · 2018-03-10T15:05:42Z

here is a script i wrote to analyze the currently open legacy bounties

from dashboard.models import Bounty
bounties = Bounty.objects.filter(current_bounty=True, web3_type='legacy_gitcoin', network='mainnet')
bounties = bounties.exclude(idx_status__in=['expired','done'])
for bounty in bounties:
    print(bounty.status, bounty.github_url)

and it's output

open https://github.com/nbanmp2/testrepo/issues/3
open https://github.com/TimVanMourik/Porcupine/issues/19
started https://github.com/ethereum/web3.py/issues/549
open https://github.com/ProjectWyvern/dao.projectwyvern.com/issues/1
submitted https://github.com/MetaMask/metamask-extension/issues/437
submitted https://github.com/ConsenSys/Tokens/issues/103
submitted https://github.com/gitcoinco/web/issues/152
open https://github.com/trufflesuite/truffle/issues/678
open https://github.com/gitcoinco/chrome_ext/issues/1
open https://github.com/lynndylanhurley/devise_token_auth/issues/976
submitted https://github.com/gitcoinco/skunkworks/issues/38
open https://github.com/ethereum/pyrlp/issues/44
submitted https://github.com/gitcoinco/web/issues/75
started https://github.com/trufflesuite/ganache-cli/issues/453
submitted https://github.com/gitcoinco/skunkworks/issues/34
open https://github.com/ethereum/remix/issues/218
submitted https://github.com/nbanmp2/testrepo/issues/1
started https://github.com/MetaMask/metamask-extension/issues/2350
submitted https://github.com/gitcoinco/web/pull/48
started https://github.com/btcsuite/btcd/issues/1089

two ideas for allowing people to manage these legacy bounties after this code is gone:

spin up legacy.gitcoin.co -- a site which runs a version of the codebase that is pinned to an old commit hash.. and allows interaction with the smart contracts.
for each legacy bounty... allow some limited functionality associated with recovering your funds [ killing the bounty (or submitting / accepting the funds) ]

mbeacom · 2018-03-12T15:22:21Z

@owocki I'm for 2 - I think option 1 brings us back to our original alternative to maintaining the existing bounties under separate views.
If it means we don't need to run separate apps, I think it would be beneficial to take the time to outline a process or introduce a mechanism to retrieve the funds more easily.

owocki · 2018-03-12T21:14:36Z

If it means we don't need to run separate apps, I think it would be beneficial to take the time to outline a process or introduce a mechanism to retrieve the funds more easily.

this makes sense to me..

maybe destroy all the legacy bounty JS and have the standardbounties JS serve up.. but IFF its a legacy bounty dont display the ability to work on any of the options (i.e. remove 'start work' submit work, accept bounty, etc) and add a button to a one-off page that allows the submitter to recover their funds.

owocki · 2018-03-13T03:26:34Z

just went through and killed all the of the bounties in that list that i owed.. now we are down to

open https://github.com/TimVanMourik/Porcupine/issues/19
open https://github.com/ethereum/pyrlp/issues/44
open https://github.com/lynndylanhurley/devise_token_auth/issues/976
started https://github.com/btcsuite/btcd/issues/1089
open https://github.com/ProjectWyvern/dao.projectwyvern.com/issues/1

owocki · 2018-03-13T03:39:34Z

#589 (comment)

i just went through all of the above comments and asked the developers on them to clawback their bounties this week ( copy )

owocki · 2018-03-13T15:17:27Z

slept on this last night to determine how we can have a bias towards action on this:

i think ill give the above parties until the end of the week (thursday) to kill their bounties.. then (only IFF any of them are leftover) i will code up a page that will allow them to interact with legacy bounty contracts and get their money back (either via kill bounty or via claim / accept).. and make that available live as the last remaining vestige of legacy bounties..

@mbeacom @jasonrhaas does that sound okay to you?

mbeacom · 2018-03-13T15:22:30Z

@owocki Sounds good to me! 🍾

mbeacom · 2018-03-13T16:58:54Z

jasonrhaas · 2018-03-13T18:23:38Z

@owocki I like it, getting closer to being able to remove legacy support 👍

… recoup its funds

owocki · 2018-03-14T16:33:15Z

@mbeacom i just completed the functionality on the page thats gonna allow a user to recoup their funds if they have a legacy bounty. see 300d6ce -- look okay?

codecov · 2018-03-14T16:44:58Z

Codecov Report

Merging #589 into master will increase coverage by 0.2%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master     #589     +/-   ##
=========================================
+ Coverage   33.97%   34.18%   +0.2%     
=========================================
  Files          92       90      -2     
  Lines        5053     5362    +309     
  Branches      584      652     +68     
=========================================
+ Hits         1717     1833    +116     
- Misses       3269     3454    +185     
- Partials       67       75      +8

Impacted Files	Coverage Δ
app/app/urls.py	`100% <ø> (ø)`	⬆️
app/dashboard/views.py	`21.42% <0%> (+2.86%)`	⬆️
app/legacy/urls.py	`100% <100%> (ø)`	⬆️
app/retail/emails.py	`24.13% <0%> (-1.18%)`	⬇️
...eting/management/commands/bounty_feedback_email.py	`0% <0%> (ø)`
app/marketing/mails.py	`16.74% <0%> (+3.02%)`	⬆️
app/dashboard/router.py	`45.28% <0%> (+7.99%)`	⬆️
app/retail/views.py	`48.87% <0%> (+8.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d7ffa...8e82928. Read the comment docs.

owocki · 2018-03-14T19:46:27Z

its weird the isort is faiing on app/marketing/webhookviews.py bc its working on my local

mbeacom · 2018-03-14T19:47:54Z

@owocki Can you update your isort ? I'm thinking it might be a version issue. isort -rc --atomic . pops with that additional blank line on my end.

owocki · 2018-03-14T20:09:59Z

just updated i sort to isort-4.3.4-py3-none-any.whl and pushed a fix

mbeacom · 2018-03-14T20:37:13Z

Looks like it's failing on eslint now. I'm not entirely sure what isort changed/fixed in the latest version, but that looks good 👍

owocki · 2018-03-15T22:24:43Z

just pushed up some eslint fixes

owocki added 2 commits March 10, 2018 07:55

removes legacy bounty handling code

190674b

isort

19b3cb9

owocki added the in progress label Mar 10, 2018

Merge branch 'master' into kevin/remove_legacy

9514dbf

Just enough legacy bounty information to be able to kill a bounty and…

300d6ce

… recoup its funds

Merge branch 'master' into kevin/remove_legacy

a696ff6

owocki changed the title ~~[WIP] destroys legacy bounty handling code~~ destroys legacy bounty handling code (except for on legacy kill bounty page) Mar 14, 2018

isort

f2be221

isort fix:

e2020d3

owocki added 2 commits March 15, 2018 16:18

lots of legacy files i missed

34ef9ec

eslint fixes'

f1d7fbc

owocki added 3 commits March 15, 2018 16:29

fun little eslint stuff

81322d7

eslint fixes

ebb59a5

eslint warnings -- grandfather in

8e82928

mbeacom approved these changes Mar 15, 2018

View reviewed changes

mbeacom added the legacy label Mar 15, 2018

owocki mentioned this pull request Mar 15, 2018

Reminder to remove the legacy/* application once those bounties are done #406

Closed

owocki merged commit a793051 into master Mar 15, 2018

owocki removed the in progress label Mar 15, 2018

mbeacom deleted the kevin/remove_legacy branch March 15, 2018 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

destroys legacy bounty handling code (except for on legacy kill bounty page) #589

destroys legacy bounty handling code (except for on legacy kill bounty page) #589

owocki commented Mar 10, 2018 •

edited

owocki commented Mar 10, 2018 •

edited

mbeacom commented Mar 12, 2018

owocki commented Mar 12, 2018

owocki commented Mar 13, 2018 •

edited

owocki commented Mar 13, 2018 •

edited

owocki commented Mar 13, 2018 •

edited

mbeacom commented Mar 13, 2018

mbeacom commented Mar 13, 2018

jasonrhaas commented Mar 13, 2018

owocki commented Mar 14, 2018

codecov bot commented Mar 14, 2018 •

edited

owocki commented Mar 14, 2018

mbeacom commented Mar 14, 2018

owocki commented Mar 14, 2018

mbeacom commented Mar 14, 2018

owocki commented Mar 15, 2018

destroys legacy bounty handling code (except for on legacy kill bounty page) #589

destroys legacy bounty handling code (except for on legacy kill bounty page) #589

Conversation

owocki commented Mar 10, 2018 • edited

Description

Still TODO

Checklist

Affected core subsystem(s)

Refers/Fixes

owocki commented Mar 10, 2018 • edited

mbeacom commented Mar 12, 2018

owocki commented Mar 12, 2018

owocki commented Mar 13, 2018 • edited

owocki commented Mar 13, 2018 • edited

owocki commented Mar 13, 2018 • edited

mbeacom commented Mar 13, 2018

mbeacom commented Mar 13, 2018

jasonrhaas commented Mar 13, 2018

owocki commented Mar 14, 2018

codecov bot commented Mar 14, 2018 • edited

Codecov Report

owocki commented Mar 14, 2018

mbeacom commented Mar 14, 2018

owocki commented Mar 14, 2018

mbeacom commented Mar 14, 2018

owocki commented Mar 15, 2018

owocki commented Mar 10, 2018 •

edited

owocki commented Mar 10, 2018 •

edited

owocki commented Mar 13, 2018 •

edited

owocki commented Mar 13, 2018 •

edited

owocki commented Mar 13, 2018 •

edited

codecov bot commented Mar 14, 2018 •

edited