add poap badges verification #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhio618
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
hhio618
force-pushed
the
poap-verification
branch
2 times, most recently
from
992eb2d
to
133be88
Compare
|
@hhio618 good progress ! I'm shifting this to draft until you wrap up the pending tasks -> do turn it on as an active PR once it's good for review |
hhio618
force-pushed
the
poap-verification
branch
from
133be88
to
a3b1ab7
Compare
|
Hey, @thelostone-mc. This feature is ready to be tested. I'll start to add some unit tests. |
Closed
thelostone-mc
approved these changes
Nov 7, 2020
hhio618
force-pushed
the
poap-verification
branch
from
d742636
to
cb6f777
Compare
danlipert
reviewed
Nov 9, 2020
danlipert
suggested changes
Nov 9, 2020
patch
Outdated
| @@ -0,0 +1,306 @@ | |||
| diff --git a/app/assets/v2/js/pages/profile-trust.js b/app/assets/v2/js/pages/profile-trust.js | |||
|
@hhio618 if you can address the comments , we'll get this in this week |
hhio618
force-pushed
the
poap-verification
branch
from
cb6f777
to
5203204
Compare
danlipert
approved these changes
Nov 10, 2020
thelostone-mc
approved these changes
Nov 11, 2020
|
@hhio618 the POAP owner account id of the user stored anywhere on the DB? during our testing we realized that multiple users could connect to the same account id , which is def a problem for anti-sybil design. would you be able to PR a fix for that? happy to pay in ETH :) |
|
Sure, I will try to fix this asap! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added POAP badges verification.
Done
WIP
Refers/Fixes
gitcoinco/skunkworks#187
Testing