Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit cart to 40 items, regardless of checkout method #8234

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Jan 12, 2021

Closes #8231

In #8145 we only limited zkSync, now we limit standard checkout also.

To test:

  • Either add 45 items to your cart, OR change maxCartItems in cart.js to a number like 2. The number set there is the max allowed.
  • If you change it to 2, add 2 items to your cart and things should look normal. Add a third and both checkout buttons should be disabled with a message

@thelostone-mc
Copy link
Member

@mds1 looks like we have lint failures !

/home/travis/build/gitcoinco/web/app/assets/v2/js/cart-ethereum-zksync.js
34:30 error Unexpected trailing comma comma-dangle
173:49 error Unexpected trailing comma comma-dangle

could you get those fixed ?

@mds1
Copy link
Contributor Author

mds1 commented Jan 14, 2021

@thelostone-mc Fixed the lint errors and rebased against master!

@thelostone-mc thelostone-mc merged commit 955f4cc into gitcoinco:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants