Send one mail instead of n mail to supporter on checkout of n grants #8258
Conversation
- Made process_grant_contribution task return grant and created subscription objects - Added batch_process_grant_contributions task to process multiple grants in one task - Added batch_thank_you_for_supporting method to render and send email for multiple grant subscriptions - Added batch_thank_you_for_supporting.html and batch_thank_you_for_supporting.txt templates - Updated grants/views.py to use new batch_process_grant_contributions task Fixes: gitcoinco#8238
tarunbhm
requested review from
amustapha,
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
could you add a video @tarunbhm ? |
There was a problem hiding this comment.
@tarunbhm code wise this make sense !
Although as opposed to adding new email template, could we replace the old ones ?
thank_you_for_supporting is used in one more place in helper.py
This is when grants are created using CELO / ZIL address
|
@thelostone-mc There is no frontend change so did not add video. In case it's still required do you want to see mail in the video? I had tested by adding logs for generated mails and had verified that only one mail was generated. I wan to avoid creating an account on sendgrid. |
|
@tarunbhm the email being sent out is new code added ->. they does qualify as having frontend changes
I would be a lot more comfortable if we could have this tested out as well cause having to rollback in cause is something was wrong in the email is painful |
I had tested by logging rendered email body both txt and html so we are covered there. As you mentioned video is required for non tech people, I will create a video with mail in inbox. |
…_for_supporting email
Description
Refers/Fixes
Fixes: #8238
Testing