Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual fallback to binance address autofill for new bounty #8260

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Jan 18, 2021

Description

Allow manual filling of binance address as a fallback to autofilling when user doesn't have Binance Wallet Extension installed.

Refers/Fixes

#8249

Testing

image

@chibie
Copy link
Contributor Author

chibie commented Jan 18, 2021

i removed autofill but i'm working on a better flow

if user doesn't have wallet extension
        display(Looks like you don't have the Binance Wallet Extension or the extension is disabled.
                     Please enter your Binance Wallet address. We are unable to validate a Binance address. Please confirm that you 
                     are using the correct Binance address.)
else:
        autofill address from extension

@PixelantDesign

@chibie chibie changed the title remove autofill for binance new bounty manual fallback to binance address autofill for new bounty Jan 19, 2021
@thelostone-mc thelostone-mc merged commit 2bdd334 into master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants