Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG/redesign #8360

Merged
merged 11 commits into from
Feb 10, 2021
Merged

GPG/redesign #8360

merged 11 commits into from
Feb 10, 2021

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Feb 4, 2021

Description

EPIC - new brand styles integration

This PR:

  • Introduces django-libsass
  • Contains a test stylesheet (./app/assets/v3/scss/main.scss) to check that libsass will work in our environment
  • Replaces bootstrap.min.css with bootstrap.scss
  • Replaces bootstrap-vue.min.css with bootstrap-vue/index.scss
  • Replaces vue-select.css with vue-select.scss
  • Adds minification rules for production env
  • Moves libs to v3/libs
  • Updates bootstrap v4.3.1 -> v4.6.0
  • Updates bootstrap.min.js v4.3.1 -> v4.6.0
  • Updates popper.min.js v1.16.0 -> v1.16.1
  • Moves v3/scss assets into v2/scss - fixing problems with collectstatic
  • Updates and internalises jQuery (v3.3.1 -> v3.5.1)
  • Fixes google tagmanager on landing
  • Implements new scss libs on landing
  • Moves libs back in to "lib" dir (./app/assets/v2/scss/lib/*)
Refers/Fixes

Fixes: #8363
Refers: #8308
Refers: #8358

@octavioamu octavioamu marked this pull request as ready for review February 5, 2021 22:01
Copy link
Contributor

@amustapha amustapha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is massive and can barely find something wrong with it. I'll give it a pass.

@thelostone-mc thelostone-mc changed the title WIP: GPG/redesign GPG/redesign Feb 10, 2021
@thelostone-mc thelostone-mc merged commit 3cdc225 into master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpg - atomic design / strip all old css
5 participants