grants api fixes - shows addresses from zksync AND from L1 #8392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes an issue where grants API output was unperformant, and also where zksync addresses were not showing up in the dataset
Refers/Fixes
https://gitcoincore.slack.com/archives/CBDTKB59A/p1611241494001400
Testing
texted locally
http://localhost:8000/grants/v1/api/export_addresses/round7.json
http://localhost:8000/grants/v1/api/export_addresses/all.json
http://localhost:8000/grants/v1/api/export_addresses/grant238.json
http://localhost:8000/grants/v1/api/export_addresses/grant238_round7.json