Cart mobile setup #8481
Merged
Cart mobile setup #8481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
octavioamu
approved these changes
Mar 4, 2021
mds1
reviewed
Mar 4, 2021
| <div class="cursor-pointer px-0 col-auto"> | ||
| <input v-model="grant.grant_comments_bool" :id="`comment-${grant.grant_id}-blank`" type="checkbox" class="d-none" :name="`comment-${grant.grant_id}`" | ||
| :checked="grant.grant_comments_bool || !!grant.grant_comments" | ||
| :disabled="grant.grant_comments ? '' : disabled" |
There was a problem hiding this comment.
Mobile view is much improved over my attempt, thanks!
One note is that after adding a few grants to my cart, then viewing the cart page, I get the the below error in the console which I believe stems from this line
Property or method "disabled" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.
found in
---> <GrantsCart>
<Root>
There was a problem hiding this comment.
Thanks Matt!! I've got that fixed 👍
thelostone-mc
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
Refers: #8445
Refers: #8451
Testing
https://www.loom.com/share/e7474c2baa754388934319062ed100ae