Integration Branch for ENS, Duniter, Facebook, PersonhoodPassport on Trust Bonus Page #8569

owocki · 2021-03-12T23:01:04Z

Description

Integration Branch for ENS, Duniter, Facebook on Trust Bonus Page under the "coming soon" area

Refers/Fixes

Testing

Tested Facebook which is working
Can't get Duniter to work + left comment on that PR
ENS working

- add more validations - *same gitcoin user and duniter user uid - *social link "gitcoin.co" checker - *certificates check - *user is member check

… integration-ens

octavioamu

left some comments and few questions

octavioamu · 2021-03-18T17:57:16Z

app/app/urls.py

+        dashboard.views.request_verify_facebook,
+        name='request_verify_facebook'
+    ),
+    url(r'^api/v0.1/profile/verify_user_google', dashboard.views.verify_user_google, name='verify_user_google'),


this on already exist 2 lines down

app/app/urls.py

octavioamu · 2021-03-18T18:06:20Z

app/assets/v2/js/pages/profile-trust.js

+    showValidation: {
+      type: Boolean,
+      required: false,
+      'default': false


not sure I believe this should be default without quotes

octavioamu · 2021-03-18T18:09:45Z

app/assets/v2/js/pages/profile-trust.js

+      this.verifyDuniter();
+    },
+    getUserHandle() {
+      this.githubHandle = trustHandle;


I don't see where trustHandle is defined, is this code working? I suppose is a global variable defined out of vue context, if that the case, ok but if not then this will be undefined.

@developerfred

octavioamu · 2021-03-18T18:10:51Z

app/assets/v2/js/pages/profile-trust.js

+    showValidation: {
+      type: Boolean,
+      required: false,
+      'default': false


I believe is without quotes I never saw it with quotes, but probably doesn't affect the code.

octavioamu · 2021-03-18T18:16:24Z

app/assets/v2/js/pages/profile-trust.js

+  jQuery.fn.shake = function(interval, distance, times) {
+    interval = typeof interval == 'undefined' ? 100 : interval;
+    distance = typeof distance == 'undefined' ? 10 : distance;
+    times = typeof times == 'undefined' ? 3 : times;
+    var jTarget = $(this);
+
+    jTarget.css('position', 'relative');
+    for (var iter = 0; iter < (times + 1); iter++) {
+      jTarget.animate({ top: ((iter % 2 == 0 ? distance : distance * -1))}, interval);
+    }
+    return jTarget.animate({ top: 0}, interval);
+  };
+
+  $(document).on('click', '#gen_passport', function(e) {
+    e.preventDefault();
+    if (document.web3network != 'rinkeby') {
+      _alert('Please connect your web3 wallet to rinkeby + unlock it', 'error', 1000);
+      return;
+    }
+    const accounts = web3.eth.getAccounts();
+
+    $.when(accounts).then((result) => {
+      const ethAddress = result[0];
+      let params = {
+        'network': document.web3network,
+        'coinbase': ethAddress
+      };
+
+      $.get('/passport/', params, function(response) {
+        let status = response['status'];
+
+        if (status == 'error') {
+          _alert(response['msg'], 'error', 5000);
+          return;
+        }
+
+        let contract_address = response.contract_address;
+        let contract_abi = response.contract_abi;
+        let nonce = response.nonce;
+        let hash = response.hash;
+        let tokenURI = response.tokenURI;
+        var passport = new web3.eth.Contract(contract_abi, contract_address);
+
+        var callback = function(err, txid) {
+          if (err) {
+            _alert(err, 'error', 5000);
+            return;
+          }
+          let url = 'https://rinkeby.etherscan.io/tx/' + txid;
+          var html = `
+<strong>Woo hoo!</strong> - Your passport is being generated.  View the transaction <a href='` + url + `' target=_blank>here</a>.
+<br><br>
+<strong>Whats next?</strong>
+<br>
+1. Please add the token contract address (` + contract_address + `) as a token to your wallet provider.
+<br>
+2. Use the Trust you've built up on Gitcoin across the dWeb!  Learn more at <a target=_blank href=https://proofofpersonhood.com>proofofpersonhood.com</a>
+
+          `;
+
+          $('.modal-body .subbody').html(html);
+          $('.modal-dialog').shake();
+        };
+
+        passport.methods.createPassport(tokenURI, hash, nonce).send({from: ethAddress}, callback);
+      });
+
+    });
+  });


why not vue here? It's ok for now I think but we are creating tech debt for the near future.

i wrestled with vue for a bit + just couldnt get it working. couldnt get the variables to scope correctly. happy to pair on rewriting it.

octavioamu · 2021-03-18T18:17:40Z

app/assets/v2/js/pages/profile-trust.js

+  $(document).on('click', '#gen_passport', function(e) {
+    e.preventDefault();
+    if (document.web3network != 'rinkeby') {
+      _alert('Please connect your web3 wallet to rinkeby + unlock it', 'error', 1000);


should be rinkeby?

yes, this is behind an is_staff flag + not in mainnet yet

app/passport/views.py

gdixon

I've left a couple of comments for @developerfred to get the tests to pass...

One thing to note for when we deploy this: we will need to make sure that we have libsodium installed everywhere that this code will run.

app/dashboard/templates/profiles/trust-vue.html

app/dashboard/tests/test_dashboard_views.py

gdixon · 2021-03-18T20:25:24Z

app/assets/v2/js/pages/profile-trust.js

+  delimiters: [ '[[', ']]' ],
+  data: function() {
+    return {
+      showValidation: false,


We're providing showValidation as a prop and defining a default value there - we don't need this ln 👍

thelostone-mc · 2021-03-23T12:53:12Z

@owocki if you can get the comments addressed -> we can get it out this week else we'll have to push this back

owocki · 2021-03-23T14:24:31Z

@developerfred can you pls resolve the duniter comments? i can resolve the ones related to PoPP

thelostone-mc · 2021-04-05T10:44:23Z

@owocki + @developerfred Could we get these fixed up by next week ?
This PR is starting to get stale and conflicts are starting to creep in

owocki · 2021-04-05T13:33:12Z

@developerfred if you cant get duniter fixed ( #7844 (comment) ) in the next day or two , i'm going to cut that code out + push the rest of this to deploy.

developerfred · 2021-04-06T23:46:04Z

@developerfred if you cant get duniter fixed ( #7844 (comment) ) in the next day or two , i'm going to cut that code out + push the rest of this to deploy.

I ended up not being able to work on that, I had external impediments. But I am focused on solving this feature.

developerfred · 2021-04-06T23:48:33Z

@owocki You can send facebook and ens, because it's ready. Because the Duniter is holding these deploys. there I am working on the feature attached.

thelostone-mc · 2021-04-08T13:43:32Z

@developerfred could i get an ETA on when you'd be able to get this ready ?
If you aren't able to wrap it up by Monday -> I'd have to figure out how to undo your changes

Ideally, I'd want to avoid doing that cause you'd have to rework your changes

gdixon

All LGTM!! 🚀

Elhamne · 2021-04-24T07:20:01Z

Hi @thelostone-mc , I just see the Facebook integration has been merged; but I get Invalid App ID error on it.

developerfred and others added 30 commits November 7, 2020 18:58

add duniter trust bonus and close skunkworks/issues/187

de0d254

Merge branch 'master' into duniter-skunkworks/issues/187

0be0187

add duniter envs on Travis.env

fbe62d2

remove client duniterpy and add call by https://g1.duniter.org/

2e4aec2

- fixed duniter and migrations

77d9c0e

- add more validations - *same gitcoin user and duniter user uid - *social link "gitcoin.co" checker - *certificates check - *user is member check

Merge branch 'master' into duniter-skunkworks/issues/187

e185e21

Merge branch 'master' into duniter-skunkworks/issues/187

387bf4b

remove duniter settings env

bd96b39

duniter migrate

d5824b5

Merge branch 'master' into duniter-skunkworks/issues/187

a00821a

Merge branch 'master' into duniter-skunkworks/issues/187

3beb603

Merge branch 'master' into duniter-skunkworks/issues/187

273b548

Merge branch 'master' into duniter-skunkworks/issues/187

b886ec8

chore: running makemigrations --merge

d460417

add test request for dashboard/views "verify_user_duniter"

c0ba381

Fixed tests assert test duniter verify

c732590

add duniter test on dashboard/tests init

e58bf7e

Merge branch 'master' into duniter-skunkworks/issues/187

79fc891

fixed ident dashboard_views

882112a

fixed test for gitcoin username

f5ebadf

change assert

37ad3bc

change assert and duniter urls

0fde356

Merge branch 'master' into duniter-skunkworks/issues/187

c0b2e47

Integrate ENS

ff55b1a

Merge branch 'master' into integration-ens

cd0b72f

Merge branch 'master' into duniter-skunkworks/issues/187

7511ece

Remove vnd step

121fbcc

Merge branch 'integration-ens' of https://github.com/moonniy/web into…

6fe7b37

… integration-ens

Merge branch 'master' into duniter-skunkworks/issues/187

0b4982c

Merge branch 'master' into integration-ens

22300ce

octavioamu suggested changes Mar 18, 2021

View reviewed changes

gdixon suggested changes Mar 18, 2021

View reviewed changes

app/dashboard/templates/profiles/trust-vue.html Outdated Show resolved Hide resolved

app/dashboard/tests/test_dashboard_views.py Show resolved Hide resolved

owocki added 3 commits March 18, 2021 14:19

fixes url

62fc510

consolidates migratoins

7387d3a

pip freeze and dependancy

e5757be

gdixon reviewed Mar 18, 2021

View reviewed changes

owocki and others added 5 commits March 18, 2021 14:40

req

709aeee

Adds libsodium-dev install to .travis.yml

1a51e71

Moves attrs from test requirements to base

1dcf055

Upgrades travis ubuntu distro (16.04 -> 18.04) to match docker

bb31405

Installs libsecp256k1-dev for travis build

b477fa9

thelostone-mc added this to Engineering-Review in PR Review Board Mar 22, 2021

gdixon moved this from Engineering-Review to Waiting on contributor in PR Review Board Mar 22, 2021

thelostone-mc added 4 commits April 9, 2021 15:36

resolve conflicts

6797013

recreate migrations

b1bb53d

work on feedback items

be95e5c

move ENS + FB to active now

85b8ab5

gdixon approved these changes Apr 20, 2021

View reviewed changes

thelostone-mc merged commit cb19557 into master Apr 20, 2021

PR Review Board automation moved this from Waiting on contributor to Done Apr 20, 2021

thelostone-mc mentioned this pull request Apr 20, 2021

proof of personhood passport staff only #8478

Closed

6 tasks

gdixon mentioned this pull request Apr 27, 2021

Rewrites assemble_leaderboards tests and backs out duniterpy integration #8829

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integration Branch for ENS, Duniter, Facebook, PersonhoodPassport on Trust Bonus Page #8569

Integration Branch for ENS, Duniter, Facebook, PersonhoodPassport on Trust Bonus Page #8569

owocki commented Mar 12, 2021 •

edited

octavioamu left a comment

octavioamu Mar 18, 2021

octavioamu Mar 18, 2021

octavioamu Mar 18, 2021

owocki Mar 23, 2021

octavioamu Mar 18, 2021

octavioamu Mar 18, 2021 •

edited

owocki Mar 18, 2021

octavioamu Mar 18, 2021

owocki Mar 18, 2021

gdixon left a comment

gdixon Mar 18, 2021

thelostone-mc commented Mar 23, 2021

owocki commented Mar 23, 2021

thelostone-mc commented Apr 5, 2021

owocki commented Apr 5, 2021

developerfred commented Apr 6, 2021

developerfred commented Apr 6, 2021

thelostone-mc commented Apr 8, 2021

gdixon left a comment

Elhamne commented Apr 24, 2021

Integration Branch for ENS, Duniter, Facebook, PersonhoodPassport on Trust Bonus Page #8569

Integration Branch for ENS, Duniter, Facebook, PersonhoodPassport on Trust Bonus Page #8569

Conversation

owocki commented Mar 12, 2021 • edited

Description

Refers/Fixes

Testing

octavioamu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octavioamu Mar 18, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gdixon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thelostone-mc commented Mar 23, 2021

owocki commented Mar 23, 2021

thelostone-mc commented Apr 5, 2021

owocki commented Apr 5, 2021

developerfred commented Apr 6, 2021

developerfred commented Apr 6, 2021

thelostone-mc commented Apr 8, 2021

gdixon left a comment

Choose a reason for hiding this comment

Elhamne commented Apr 24, 2021

owocki commented Mar 12, 2021 •

edited

octavioamu Mar 18, 2021 •

edited