Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes fly-out behaviour on side-cart and tidies up card/list-view #8600

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Mar 15, 2021

Description

This PR will tidy up the Grants/Explorer side-cart and both (grid/list) views so that the side-cart will be positioned correctly without squashing any content (at all break-points).

Refers/Fixes

Refers: #8483 (comment)
Fixes: https://gitcoincore.slack.com/archives/CCL5Q0G5S/p1615520200022900

Testing

https://www.loom.com/share/d7e4e752af9748828654fe65133b7e13

Copy link
Contributor

@PixelantDesign PixelantDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @gdixon.

@thelostone-mc thelostone-mc merged commit 2396e9f into stable Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants