Implements the remaining component library changes #8622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
changed the title
|
looking good! |
|
Is there a way to publish each component on a page so that we can preview/ play with it? |
gdixon
changed the title
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
All changes are now in - I'll check if we can switch over the branch on staging so that you can all review 😄 |
thelostone-mc
approved these changes
Mar 25, 2021
chibie
approved these changes
Mar 26, 2021
iRhonin
pushed a commit
to iRhonin/web
that referenced
this pull request
Apr 23, 2021
* Replaces all instances of #3E00FF with #6F3FF5 * Replaces remaining .button types with .btn types * Fixes minor style bugs on landing and activity feed * Fixes hackathon dashboard styles * Fixes form styles and adds error state to inputs/selects/btn-radios etc... * Tidy up townsquare * Implements .bs-alert to replace .alert * Updates .nav-tabs to primary color * Implements .gc-accordion design and drops jquery accordion show/hide * Double quotes -> single quotes * Cleans up styles * Adds component style guide * Drops sass_experiment * Fixes linting error * Removes dead code * Adds third-party libraries, typography examples and color examples to style guide * Fixes vs-select min-height and adds font-weight:bold to selected accordion Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.buttoninstances with.btnequivalentsUpdate non vue forms to use vue (or style to match vue forms)We should open these as separate PR's so that we can prioritise accordinglyThe style guide will be available in dev environments at http://localhost:8000/styleguide/componentsRefers/Fixes
Refers: #8381
Testing
Ongoing: