gpg/jtbd-landings #8706
gpg/jtbd-landings #8706
Conversation
gpg/jtbd-backend
octavioamu
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
| ).order_by('-_val_usd_db').values('_val_usd_db', 'title', 'issue_description')[0:2]) | ||
|
|
||
| # WalletConnect | ||
| featured_grant = Grant.objects.filter(pk=275).first() |
There was a problem hiding this comment.
^ shouldn't this be grant with most matching as opposed to hardcoding walletconnect ?
There was a problem hiding this comment.
A friend of mine use to say "is what it is" :P.
But was asked to be that specific one.
| view=view, | ||
| key=keyword, | ||
| data=data, | ||
| ) |
There was a problem hiding this comment.
^ looks like page starting to grow in length !
Would it make sense to create
app/perftools/management/commands/cache/jtbd.py and throw them there
We'll have to do it for the others as well
we can import them here and use them in create_page_cache
There was a problem hiding this comment.
Agree, that is a good idea
There was a problem hiding this comment.
^ let's get this done as well before we merge @chibie / @octavioamu
There was a problem hiding this comment.
^ let's get this done as well before we merge @chibie / @octavioamu
* Adds details to jtbd connect page * Adds greys/lighter and border-bottom-* and border-right-* * Updates testimonial * Adds a custom filter to convert str to datetime * Adds ctas, fixes padding and switches page specific styling for global utilities * Adds border to left of .gc-accordion (using .gc-accordion-border) * Fixes padding on hackathons area * Scroll to element rather than bottom (so we stop in the right place on mobile) * Fixes semantics and swaps discord image for svg * Fixes padding * Updates svgs and accordion-panel text * Updates testimonial details and drops twitter link * Fixes indentation, urls and spacing on ready-to-connect * Fixes accordion so img has padding right without shrinking * Implements conditional states for hackathon list * Drops to_date in favour of date_fromisoformat * Deletes to_date filter
* start earn page * + ways to earn * hackathons + bounties * testimonial + grants * link CTAs * remove unused css * finish pr * review fixes * little fix * swap p -> h5 * use filled svgs + accordion fixes * consistency
* Adds details to jtbd connect page * Adds greys/lighter and border-bottom-* and border-right-* * Updates testimonial * Adds a custom filter to convert str to datetime * Adds ctas, fixes padding and switches page specific styling for global utilities * Adds border to left of .gc-accordion (using .gc-accordion-border) * Fixes padding on hackathons area * Scroll to element rather than bottom (so we stop in the right place on mobile) * Adds details to jtbd learn page * Fixes semantics and swaps discord image for svg * Fixes semantics * Fixes padding * Updates svgs and accordion-panel text * Updates accordion-panel text * Drops twitter link * Updates testimonial details and drops twitter link * Updates testimonial details and uses static template tag * Fixes indentation, urls and spacing on ready-to-connect * Fixes indentation, urls and spacing on ready-to-learn * Fixes accordion so img has padding right without shrinking * Fixes accordion so img has padding right without shrinking * Implements conditional states for hackathon list * Implements conditional states for hackathon list * Drops to_date in favour of date_fromisoformat * Drops to_date in favour of date_fromisoformat * Deletes to_date filter
* Adds details to jtbd connect page * Adds greys/lighter and border-bottom-* and border-right-* * Updates testimonial * Adds a custom filter to convert str to datetime * Adds ctas, fixes padding and switches page specific styling for global utilities * Adds border to left of .gc-accordion (using .gc-accordion-border) * change fund * set layout cards * fund style and head data * scroll behavior Co-authored-by: Graham Dixon <graham@gdixon.co.uk>
|
just tested these. looks like they are coming along some QA items:
|
|
to answer some of @owocki's QQs
==
Great work - it's really coming along! Let's see it again with real data soon. |
…or missing twitter_handles / github_handles / avatar_url's)
There was a problem hiding this comment.
Looking awesome!
There are a few things others have already noted above but overall it's coming along so nicely.
I noticed just a few things
I'm not sure if this is because the data isn't hooked in or not but we'd like to highlight these project. This was a discussion I had with Scott.
On the accordion section we'd like to use filled illustrations/animations
Thanks Octavio!
|
@gdixon already did the changes guys please review if something else. |
|
Hey team! I'm noticing across all of the pages, the testimonials area body copy is not as large as it should be --see the designed version to compare This is the design - we have defined it as body large,
Here is a screenshot from the build
Earn, Connect, Learn Pages H3 should be Franklin font as seen here
This is the screenshot of the build
|
app/retail/views.py
Outdated
| 'card_desc': _('There’s No Better Way To Fund Open Source Projects') | ||
| } | ||
| context.update(data) | ||
| return TemplateResponse(request, 'jtbd/fund.html', context) |
There was a problem hiding this comment.
^ @chibie Is it worth DRY-ing those code ?
There was a problem hiding this comment.
you think to create just a function with a condition? or how can be dry?
Im ok on having it on their own def but open to suggestions
There was a problem hiding this comment.
you think to create just a function with a condition
Yup ! exactly cause only the
data/title / *.html are different.
If it's an overkill -> then let's leave it like this
Description
Refers/Fixes
#8658
Testing